Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix typo #2141

Merged
merged 2 commits into from
Jun 1, 2017
Merged

fix typo #2141

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9920832
Update CONTRIBUTING.md
Thieffen May 23, 2017
fe8f612
Update NEWS.md
Thieffen May 23, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ If you're not familiar with git or github, please start by reading <http://r-pkg
See http://docs.ggplot2.org/dev/vignettes/development.html for more details.
--->

Pull requests will be evaluated against the a seven point checklist:
Pull requests will be evaluated against a seven point checklist:

1. __Motivation__. Your pull request should clearly and concisely motivates the
need for change. Unfortunately neither Winston nor I have much time to
Expand All @@ -89,7 +89,7 @@ Pull requests will be evaluated against the a seven point checklist:
and don't submit any others until the first one has been processed.

1. __Use ggplot2 coding style__. Please follow the
[official ggplot2 style](http://adv-r.had.co.nz/Style.html). Maintaing
[official ggplot2 style](http://adv-r.had.co.nz/Style.html). Maintaining
a consistent style across the whole code base makes it much easier to
jump into the code. If you're modifying existing ggplot2 code that
doesn't follow the style guide, a separate pull request to fix the
Expand Down
2 changes: 1 addition & 1 deletion NEWS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,7 +192,7 @@ There were also a number of other smaller changes

* The `theme()` constructor now has named arguments rather than ellipses. This
should make autocomplete substantially more useful. The documentation
(including exampes) has been considerably improved.
(including examples) has been considerably improved.

* Built-in themes are more visually homogeneous, and match `theme_grey` better.
(@jiho, #1679)
Expand Down