Position stack+text geom

[ikosmidis]

closes #2709

[paleolimbot]

Thank you for this PR...it looks great! Could you add a test in tests/testthat/test-position-stack.R to make sure that this bug is fixed for all time? Something like this would work quite well:

test_that("position_stack() can stack when ymax is NA", {
  df <- data_frame(x = c(1, 1), y = c(1, 1))
  p <- ggplot(df, aes(x, y, ymax = NA_real_)) + geom_point(position = "stack")
  
  # expect something about layer_data(p)
})

[ikosmidis]

Thank you for this PR...it looks great! Could you add a test in tests/testthat/test-position-stack.R to make sure that this bug is fixed for all time?

Thanks. I am afraid I am short of time here to write a proper test, but your proposal looks good; something like

expect_equal(layer_data(p)$y, c(1, 2))

should be sufficient. Feel free to add it directly once the pull request is approved.

[lock]

This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/