Use rlang::check_installed() #4375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, I think we can use |
|
Yeah, I agree; I think this is better. Added! It now looks like this, depending on the function:
|
yutannihilation
approved these changes
Mar 18, 2021
|
✔️ Added to news Thanks! 🙏 |
|
Thanks! |
leogama
added a commit
to leogama/ggtern
that referenced
this pull request
Jul 5, 2021
ggplot2 removed `try_require` in favor of rlang's `check_installed` function. See tidyverse/ggplot2#4375
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces various
requireNamespace()+abort()checks with the new rlang functioncheck_installed(), which offers to install the suggested package then proceeds or aborts. This PR also bumps the rlang dependency to 0.4.10I didn't use the
reasonargument in anycheck_installed()calls, which can add a bit of context. I'd be happy to add that, if desired.Closes #4370, fixes #4344