purrr style lambda notation in scale arguments #4427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sync branches
Sync with tidyverse/ggplot2
|
I came across issue #4103 as well, which seemed related and worth mentioning. |
yutannihilation
approved these changes
Apr 20, 2021
Co-authored-by: Hiroaki Yutani <yutani.ini@gmail.com>
|
@thomasp85 |
|
Sorry for lack of response, go ahead and merge |
|
It's fine. Thanks for confirming! |
netique
added a commit
to netique/ggplot2
that referenced
this pull request
May 6, 2021
scale part was resolved by tidyverse#4427
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to enable purrr style lambda notation for scale arguments that accept functions (
limits,breaks,minor_breaks,labels,rescalerandoob). It does so by converting formulas to functions in the scale constructors. Thomas mentioned that lambda notation should work in #4173 (comment), but the notation is currently not enabled.This PR has partial overlap in scope and in functions altered with #4188. Notable differences are that this PR doesn't touch facet labellers, but applies the lambda notation to more arguments and in all three types of scales (continuous, binned and discrete).
Thank you for considering!