geom_text() drops rows with angle = NA

[teunbrand]

This PR aims to fix #2757.

Briefly, it adds the angle to the non-missing aesthetics, causing the GeomText$handle_na() method to drop these observations with missing angles.

[teunbrand]

Tests fail on R devel due to update to the graphics engine and its interaction with vdiffr/svglite.

From the R-devel/NEWS site:

Thu, 26 Jan 2023
CHANGES IN R-devel GRAPHICS
The graphics engine version, ‘R_GE_version’, has been bumped to ‘16’ and so packages that provide graphics devices should be reinstalled.

The ‘grDevices’ and ‘grid’ packages have new functions for rendering typeset glyphs, primarily: ‘grDevices::glyphInfo()’ and ‘grid::grid.glyph()’.

Rendering of typeset glyphs is only supported so far on the Cairo-based graphics devices and on the ‘pdf()’ device.

[yutannihilation]

Good catch. Could you bump the cache-version to clear the packages compiled with an outdated version of R?

ggplot2/.github/workflows/R-CMD-check.yaml

Line 62 in 15cb2fb

cache-version: 2

[teunbrand]

Thanks! That seems to have solved the issue.

[yutannihilation]

Looks good! When I did a similar fix #3491 on geom_sf(), I accidentally broke some valid use cases, but I bet there's no such a downside in geom_text()'s case.

[teunbrand]

Thanks! I think we should be safe too; it would always throw an error and now it doesn't.