Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Formats when writing date/time/datetime #81

Open
jennybc opened this issue Dec 21, 2019 · 3 comments
Open

Formats when writing date/time/datetime #81

jennybc opened this issue Dec 21, 2019 · 3 comments

Comments

@jennybc
Copy link
Member

jennybc commented Dec 21, 2019

It needs to be possible for the user to somehow influence this. Possibilities include attaching this info to columns of the to-be-written data, having some sort of a "write spec", or an argument in writing functions.

@mattle24
Copy link

mattle24 commented Aug 7, 2020

Hi @jennybc! I and a few other people are interested in this functionality and Sheets Date and Number formats more broadly. Is this an issue that we could try working on a PR for?

@jennybc
Copy link
Member Author

jennybc commented Aug 7, 2020

In my mind, this is part of a broader notional project about column specification, both for reading and writing (and probably across packages, e.g. readxl, readr).

Re: date and number formats, I think all of that needs to be handled a bit like I'm currently handling formulas:

https://googlesheets4.tidyverse.org/reference/gs4_formula.html

I think we need a set of S3 classes in order to address these different types of cells/columns and then they carry their format as an attribute.

Just so you know, I don't think an external PR is likely to be merged, because whatever happens needs to fit nicely into a broader tidyverse/vctrs context. But, with that caveat, you are still welcome to do some sort of pilot study that meets your immediate needs. Such experiments certainly can lead to interesting insights that help to flesh out the design specs for the more permanent solution.

@mattle24
Copy link

mattle24 commented Aug 7, 2020

That makes a ton of sense, thanks for explaining your thinking! I think we'll fork the repo and try out some things to fit our needs -- and hopefully some of that can be helpful to you down the road.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants