Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added new examples to parse_number #1070

Merged
merged 2 commits into from
Jan 31, 2020
Merged

Added new examples to parse_number #1070

merged 2 commits into from
Jan 31, 2020

Conversation

cdhowe
Copy link
Contributor

@cdhowe cdhowe commented Jan 31, 2020

Fixes #1057

@batpigandme batpigandme added the tidy-dev-day 🤓 Tidyverse Developer Day rstd.io/tidy-dev-day label Jan 31, 2020
jennybc
jennybc reviewed Jan 31, 2020
View reviewed changes
R/collectors.R Outdated Show resolved Hide resolved
R/collectors.R Outdated Show resolved Hide resolved
jimhester
jimhester requested changes Jan 31, 2020
View reviewed changes
Copy link
Collaborator

@jimhester jimhester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the british pounds example for reasons stated inline, then we can approve this change.

@cdhowe
Copy link
Contributor Author

cdhowe commented Jan 31, 2020

Changed examples to address comments -- specifically dropping the example with the pound sign and shortening numbers to we don't need to adjust digits.

@cdhowe cdhowe closed this Jan 31, 2020
@cdhowe cdhowe reopened this Jan 31, 2020
@jimhester
Copy link
Collaborator

Great, thanks @cdhowe!

@jimhester jimhester self-requested a review January 31, 2020 22:23
@jimhester jimhester merged commit 829f39a into tidyverse:master Jan 31, 2020
@hadley hadley mentioned this pull request Apr 3, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jennybc jennybc jennybc left review comments

@jimhester jimhester jimhester approved these changes

Assignees
No one assigned
Labels
tidy-dev-day 🤓 Tidyverse Developer Day rstd.io/tidy-dev-day
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Better examples for parse_number()
4 participants
@cdhowe @jimhester @jennybc @batpigandme