New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent infinite loop reading xls w/ 65536 rows #432

Merged
merged 2 commits into from Mar 17, 2018

Conversation

Projects
None yet
1 participant
@jennybc
Member

jennybc commented Mar 16, 2018

Fixes #373

Thanks @vkapartzianis! I took a slightly different approach to the fix, but your diagnosis and PR (#416) made this much easier. I've put you in the NEWS bullet.

jennybc added some commits Mar 16, 2018

@jennybc jennybc force-pushed the bugfix-373-infinite-loop branch from 0354608 to 7a43547 Mar 16, 2018

@jennybc jennybc merged commit 73a8c3c into master Mar 17, 2018

3 of 4 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@jennybc jennybc deleted the bugfix-373-infinite-loop branch Mar 20, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment