Freshen up the tests around crashing #464
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivated by:
This refers to the fact that, at the time of writing,
callr:::crash()
does not crash on R devel, but instead throws an error. So reprex's tests around its behaviour when R crashes are failing on CRAN's checks on R-devel.I'm updating to use a different way of crashing R (but @gaborcsardi says he'll probably update callr's R-crashing code) and also adding
skip_on_cran()
, as it seems a bit fraught to test crashing R there.