Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add_rownames enhancement #8

Closed
krlmlr opened this issue Dec 16, 2015 · 3 comments · Fixed by #11
Closed

add_rownames enhancement #8

krlmlr opened this issue Dec 16, 2015 · 3 comments · Fixed by #11
Milestone
1.2

Comments

@krlmlr
Copy link
Member

krlmlr commented Dec 16, 2015

Fixes tidyverse/dplyr#1564.

@zhilongjia: This sounds reasonable, but I think there should be two separate functions. Would you like to contribute to this package?
@zhilongjia
Copy link
Contributor

Ok. Function name suggestion? col2rowname? compatible with add_rownames.

@krlmlr
Copy link
Member Author

krlmlr commented Dec 17, 2015

How about use_as_rownames()? We can still change the name later.

@zhilongjia zhilongjia mentioned this issue Dec 18, 2015
Merged
@krlmlr krlmlr modified the milestone: 1.0 Jan 25, 2016
@krlmlr krlmlr modified the milestones: 1.0, 2.0 Mar 2, 2016
@krlmlr krlmlr closed this as completed in #11 Mar 8, 2016
@github-actions
Copy link
Contributor

This old thread has been automatically locked. If you think you have found something related to this, please open a new issue and link to this old issue if necessary.

@github-actions github-actions bot locked and limited conversation to collaborators Dec 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.2
Development

Successfully merging a pull request may close this issue.

use_as_rownames function #8 zhilongjia/tibble
2 participants
@zhilongjia @krlmlr