Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hoist(): simplify only works for all columns or none #995

Closed
mgirlich opened this issue Jul 16, 2020 · 3 comments · Fixed by #1231
Closed

hoist(): simplify only works for all columns or none #995

mgirlich opened this issue Jul 16, 2020 · 3 comments · Fixed by #1231
Labels
feature a feature request or enhancement rectangling 🗄️ converting deeply nested lists into tidy data frames

Comments

@mgirlich
Copy link
Contributor

The .simplify argument doesn't allow to choose which columns should be simplified. One can only choose between all columns (TRUE) or none (FALSE). It would be nicer if one could choose which columns should be simplified.

@hadley
Copy link
Member

hadley commented Aug 28, 2020

I think that's reasonable, but it's not clear what the interface should be. A logical vector? A character vector of variables to simplify? A tidyselect specification?

@hadley hadley added feature a feature request or enhancement rectangling 🗄️ converting deeply nested lists into tidy data frames labels Aug 28, 2020
@mgirlich
Copy link
Contributor Author

Tidyselect specification
+ flexible
+ known to users
- very different from how to specify ptype and transform

Character vector
- feels mostly like an inferior version of the tidyselect specification

(Named) logical vector
+ more similar to ptype and transform
- less flexible than tidyselect

I like the flexibility one gains with the tidyselect specifiation but as ptype and transform do not provide it and tidyselect isn't used in other parts of the functions I'd go with a logical vector.

@hadley
Copy link
Member

hadley commented Nov 12, 2021

@DavisVaughan named list solution sounds good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature a feature request or enhancement rectangling 🗄️ converting deeply nested lists into tidy data frames
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants