New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use get() instead of getS3method() for R < 3.3 #205

Merged
merged 3 commits into from Jun 14, 2016

Conversation

Projects
None yet
3 participants
@krlmlr
Member

krlmlr commented Jun 13, 2016

Fixes #202. Tested locally on R 3.2.5 and R 3.3-patched.

@krlmlr

This comment has been minimized.

Member

krlmlr commented Jun 13, 2016

Wanted to add NEWS entry, but release branch doesn't seem to be merged yet.

@itsdalmo

This comment has been minimized.

itsdalmo commented Jun 13, 2016

Beginner question here; Why not use a if statement here which dep. on R version? Is it because of performance or something else? Also, how long will you have to wait before exchanging get with getS3method and bumping the R version dependency (if ever)?

@krlmlr

This comment has been minimized.

Member

krlmlr commented Jun 13, 2016

I just went the path of least resistance here. The code is hit by about 10 tests, so if it ever breaks, we may think again about updating it.

@hadley

This comment has been minimized.

Member

hadley commented Jun 13, 2016

Just updated the release status

@krlmlr

This comment has been minimized.

Member

krlmlr commented Jun 14, 2016

Are you, too, now receiving GitHub notifications when somebody pushes to an active pull request?

@jankatins jankatins referenced this pull request Jun 14, 2016

Closed

Add drop_na verb #201

@hadley hadley merged commit be93615 into tidyverse:master Jun 14, 2016

3 checks passed

codecov/patch 100% of diff hit (target 92.43%)
Details
codecov/project 92.43% (+0.00%) compared to 059fb35
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@hadley

This comment has been minimized.

Member

hadley commented Jun 14, 2016

Thanks!

And yes - it seems to be a new github feature. I haven't seen it announced yet though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment