-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Navbar is extending too far down on small screens #42
Comments
This also happens with tidyverse packages in the wild, see e.g. ggplot2 (Screenshot from Firefox on a Moto G5 plus (Full HD Screen)). With even longer package names, the "part of ..." text gets wrapped on a new line. There are two issues IMO:
Is this something that could be fixed directly in pkgdown? |
You could hide the Update this div: tidytemplate/inst/pkgdown/templates/navbar.html Lines 14 to 17 in 27af8fd
with: <div class="info hidden-xs hidden-sm"> |
Also we added headroom to pkgdown so the navbar will disappear on mobile when scrolling. |
@jayhesselberth headroom is only a partial solution IMO, like I mentioned in r-lib/pkgdown#1041 (comment). But hiding the "part of ..." ought to work with the usual package name lengths. |
We haven't noticed this issue on any tidyverse packages (because their names are so short), but when the name of a package is long enough and the screen isn't very wide, you end up moving the
"part of tidymodels 0.0.1"
to the next line, which can cover up some of the screen, especially on mobile.Here is what it looks like on a full screen laptop (all good here)
But when you shrink the screen really far you get...
Unfortunately, this is what it defaults to on most mobile screens because they aren't wide enough. Here is my iPhone 6s:
Clearly I just need to choose shorter package names.
The text was updated successfully, but these errors were encountered: