Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove use_pointcloud_container #200

Merged
merged 3 commits into from
Feb 8, 2024

Conversation

kminoda
Copy link
Contributor

@kminoda kminoda commented Jan 19, 2024

Signed-off-by: kminoda <koji.minoda@tier4.jp>
@kminoda kminoda marked this pull request as draft January 19, 2024 02:05
@kminoda kminoda marked this pull request as ready for review January 29, 2024 05:10
@kminoda kminoda requested a review from miursh February 7, 2024 10:34
@kminoda
Copy link
Contributor Author

kminoda commented Feb 7, 2024

@miursh Sorry I forgot to assign you as a reviewer in this PR 🙏
Would you also check this?

miursh
miursh previously approved these changes Feb 7, 2024
Copy link
Contributor

@miursh miursh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kminoda
Copy link
Contributor Author

kminoda commented Feb 8, 2024

@miursh Sorry would you approve again? 🙏 (Fixed pre-commit)

@kminoda kminoda merged commit d5c5822 into tier4/universe Feb 8, 2024
9 of 10 checks passed
@kminoda kminoda deleted the feat/remove_use_pointcloud_container branch February 8, 2024 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants