docs: simplify installation instructions #203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Max SCHMELLER <max.schmeller@tier4.jp>
Signed-off-by: Max SCHMELLER <max.schmeller@tier4.jp>
Signed-off-by: Max SCHMELLER <max.schmeller@tier4.jp>
Signed-off-by: David Wong <david.wong@tier4.jp>
|
drwnz
approved these changes
Oct 1, 2024
| # Build Nebula | ||
| colcon build --symlink-install --cmake-args -DCMAKE_BUILD_TYPE=Release | ||
| colcon build --symlink-install --cmake-args -DCMAKE_BUILD_TYPE=Release -DCMAKE_EXPORT_COMPILE_COMMANDS=1 |
There was a problem hiding this comment.
CMAKE_EXPORT_COMPILE_COMMANDS - I'm guessing this is for Clang? With this option set I do get a compile_commands.json but I also get a CMake Warning:
Manually-specified variables were not used by the project:
CMAKE_EXPORT_COMPILE_COMMANDS
I added a commit that adds an ignore to the meta project to remove the warning.
There was a problem hiding this comment.
mojomex
added a commit
to mojomex/nebula
that referenced
this pull request
Oct 2, 2024
* docs: remove obsolete note about transport drivers Signed-off-by: Max SCHMELLER <max.schmeller@tier4.jp> * docs: remove recommendation to clone into `src` directory Signed-off-by: Max SCHMELLER <max.schmeller@tier4.jp> * chore: update link to about page Signed-off-by: Max SCHMELLER <max.schmeller@tier4.jp> * chore: add cmake ignore to meta package Signed-off-by: David Wong <david.wong@tier4.jp> --------- Signed-off-by: Max SCHMELLER <max.schmeller@tier4.jp> Signed-off-by: David Wong <david.wong@tier4.jp> Co-authored-by: David Wong <david.wong@tier4.jp>
mojomex
added a commit
that referenced
this pull request
Oct 3, 2024
* chore: fix case style in common modules and their usages Signed-off-by: Max SCHMELLER <max.schmeller@tier4.jp> * chore(hesai): fix case style Signed-off-by: Max SCHMELLER <max.schmeller@tier4.jp> * chore(continental): fix case style Signed-off-by: Max SCHMELLER <max.schmeller@tier4.jp> * chore(robosense): fix case style Signed-off-by: Max SCHMELLER <max.schmeller@tier4.jp> * chore(velodyne): fix case style Signed-off-by: Max SCHMELLER <max.schmeller@tier4.jp> * chore: fix typos in the SetVelocity Vehicle function (#204) * docs: simplify installation instructions (#203) * docs: remove obsolete note about transport drivers Signed-off-by: Max SCHMELLER <max.schmeller@tier4.jp> * docs: remove recommendation to clone into `src` directory Signed-off-by: Max SCHMELLER <max.schmeller@tier4.jp> * chore: update link to about page Signed-off-by: Max SCHMELLER <max.schmeller@tier4.jp> * chore: add cmake ignore to meta package Signed-off-by: David Wong <david.wong@tier4.jp> --------- Signed-off-by: Max SCHMELLER <max.schmeller@tier4.jp> Signed-off-by: David Wong <david.wong@tier4.jp> Co-authored-by: David Wong <david.wong@tier4.jp> --------- Signed-off-by: Max SCHMELLER <max.schmeller@tier4.jp> Signed-off-by: David Wong <david.wong@tier4.jp> Co-authored-by: JonasKrug <JonasKrug@users.noreply.github.com> Co-authored-by: David Wong <david.wong@tier4.jp>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
Related Links
boost_tcp_driverDependency innebula_hw_interfacesPackage #197 -- installation failed for a user due to unclear instructions in the readmeDescription
Simplify the readme/installation pages:
boost_and thus not conflicting with ROS' transport_drivers anymoresrcdirectory and instead recommend direct cloningsrcdirectory is one extra step which is not necessarysrcPre-Review Checklist for the PR Author
PR Author should check the checkboxes below when creating the PR.
Checklist for the PR Reviewer
Reviewers should check the checkboxes below before approval.
Post-Review Checklist for the PR Author
PR Author should check the checkboxes below before merging.
CI Checks