Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix case styles #205

Merged
merged 9 commits into from
Oct 3, 2024
Merged

Conversation

mojomex
Copy link
Collaborator

@mojomex mojomex commented Oct 2, 2024

PR Type

  • Improvement

Related Links

Description

Case styles in Nebula are not consistent, and Clang-Tidy marks almost every file as having warnings because of that.

This will be important for enforcing coding styles in contributed code as well.

🟢 This PR contains semi-automatic changes only and has been confirmed to build. Thus, a cursory review is enough.

Review Procedure

No special review necessary.

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

  • Assign PR to reviewer

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

  • Commits are properly organized and messages are according to the guideline
  • (Optional) Unit tests have been written for new behavior
  • PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

  • All open points are addressed and tracked via issues or tickets

CI Checks

  • Build and test for PR: Required to pass before the merge.

mojomex and others added 7 commits October 2, 2024 16:02
Signed-off-by: Max SCHMELLER <max.schmeller@tier4.jp>
Signed-off-by: Max SCHMELLER <max.schmeller@tier4.jp>
Signed-off-by: Max SCHMELLER <max.schmeller@tier4.jp>
Signed-off-by: Max SCHMELLER <max.schmeller@tier4.jp>
Signed-off-by: Max SCHMELLER <max.schmeller@tier4.jp>
* docs: remove obsolete note about transport drivers

Signed-off-by: Max SCHMELLER <max.schmeller@tier4.jp>

* docs: remove recommendation to clone into `src` directory

Signed-off-by: Max SCHMELLER <max.schmeller@tier4.jp>

* chore: update link to about page

Signed-off-by: Max SCHMELLER <max.schmeller@tier4.jp>

* chore: add cmake ignore to meta package

Signed-off-by: David Wong <david.wong@tier4.jp>

---------

Signed-off-by: Max SCHMELLER <max.schmeller@tier4.jp>
Signed-off-by: David Wong <david.wong@tier4.jp>
Co-authored-by: David Wong <david.wong@tier4.jp>
@mojomex mojomex self-assigned this Oct 2, 2024
@mojomex mojomex requested a review from drwnz October 2, 2024 07:07
Copy link

codecov bot commented Oct 2, 2024

Codecov Report

Attention: Patch coverage is 23.02498% with 1140 lines in your changes missing coverage. Please review.

Project coverage is 25.76%. Comparing base (d881d5b) to head (8919d66).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
nebula_ros/src/velodyne/hw_monitor_wrapper.cpp 0.00% 263 Missing ⚠️
...a_velodyne_hw_interfaces/velodyne_hw_interface.cpp 0.00% 98 Missing ⚠️
...continental/continental_srr520_decoder_wrapper.cpp 0.00% 55 Missing ⚠️
..._hw_interfaces/continental_ars548_hw_interface.cpp 0.00% 52 Missing ⚠️
...continental/continental_ars548_decoder_wrapper.cpp 0.00% 52 Missing ⚠️
...ontinental/decoders/continental_srr520_decoder.cpp 54.08% 32 Missing and 13 partials ⚠️
nebula_ros/src/hesai/hesai_ros_wrapper.cpp 0.00% 42 Missing ⚠️
..._hw_interfaces/continental_srr520_hw_interface.cpp 0.00% 40 Missing ⚠️
nebula_ros/src/robosense/robosense_ros_wrapper.cpp 0.00% 38 Missing ⚠️
nebula_ros/src/hesai/hw_monitor_wrapper.cpp 0.00% 37 Missing ⚠️
... and 47 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #205      +/-   ##
==========================================
+ Coverage   25.75%   25.76%   +0.01%     
==========================================
  Files          99       99              
  Lines        8757     8755       -2     
  Branches     2173     2203      +30     
==========================================
+ Hits         2255     2256       +1     
+ Misses       6115     6112       -3     
  Partials      387      387              
Flag Coverage Δ
differential 25.76% <23.02%> (?)
total ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Oct 2, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
12.0% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

Copy link
Collaborator

@drwnz drwnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed that it builds and runs without issue. It's a bit scary to see everything become snake case but seems that's what ROS orders, so I guess it's OK!

@mojomex mojomex merged commit f43a28d into tier4:main Oct 3, 2024
11 of 13 checks passed
@mojomex mojomex deleted the chore/case-style-fixes branch October 3, 2024 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants