-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: fix case styles #205
Conversation
Signed-off-by: Max SCHMELLER <max.schmeller@tier4.jp>
Signed-off-by: Max SCHMELLER <max.schmeller@tier4.jp>
Signed-off-by: Max SCHMELLER <max.schmeller@tier4.jp>
Signed-off-by: Max SCHMELLER <max.schmeller@tier4.jp>
Signed-off-by: Max SCHMELLER <max.schmeller@tier4.jp>
* docs: remove obsolete note about transport drivers Signed-off-by: Max SCHMELLER <max.schmeller@tier4.jp> * docs: remove recommendation to clone into `src` directory Signed-off-by: Max SCHMELLER <max.schmeller@tier4.jp> * chore: update link to about page Signed-off-by: Max SCHMELLER <max.schmeller@tier4.jp> * chore: add cmake ignore to meta package Signed-off-by: David Wong <david.wong@tier4.jp> --------- Signed-off-by: Max SCHMELLER <max.schmeller@tier4.jp> Signed-off-by: David Wong <david.wong@tier4.jp> Co-authored-by: David Wong <david.wong@tier4.jp>
2f405db
to
f0a8588
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #205 +/- ##
==========================================
+ Coverage 25.75% 25.76% +0.01%
==========================================
Files 99 99
Lines 8757 8755 -2
Branches 2173 2203 +30
==========================================
+ Hits 2255 2256 +1
+ Misses 6115 6112 -3
Partials 387 387
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Quality Gate failedFailed conditions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed that it builds and runs without issue. It's a bit scary to see everything become snake case but seems that's what ROS orders, so I guess it's OK!
PR Type
Related Links
Description
Case styles in Nebula are not consistent, and Clang-Tidy marks almost every file as having warnings because of that.
This will be important for enforcing coding styles in contributed code as well.
🟢 This PR contains semi-automatic changes only and has been confirmed to build. Thus, a cursory review is enough.
Review Procedure
No special review necessary.
Pre-Review Checklist for the PR Author
PR Author should check the checkboxes below when creating the PR.
Checklist for the PR Reviewer
Reviewers should check the checkboxes below before approval.
Post-Review Checklist for the PR Author
PR Author should check the checkboxes below before merging.
CI Checks