Skip to content

Conversation

bkane-msft
Copy link
Contributor

Removed unnecessary 'None' argument in client initialization that caused a compilation error

@ti-chi-bot ti-chi-bot bot added contribution This PR is from a community contributor. dco-signoff: no Indicates the PR's author has not signed dco. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 28, 2025
Copy link

ti-chi-bot bot commented Aug 28, 2025

Welcome @bkane-msft!

It looks like this is your first PR to tikv/client-rust 🎉.

I'm the bot to help you request reviewers, add labels and more, See available commands.

We want to make sure your contribution gets all the attention it needs!



Thank you, and welcome to tikv/client-rust. 😃

@ti-chi-bot ti-chi-bot bot added the first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. label Aug 28, 2025
Removed unnecessary 'None' argument in client initialization that caused a compilation error

Signed-off-by: Benjamin Kane <92759008+bkane-msft@users.noreply.github.com>
@ti-chi-bot ti-chi-bot bot added dco-signoff: yes Indicates the PR's author has signed the dco. and removed dco-signoff: no Indicates the PR's author has not signed dco. labels Aug 28, 2025
Copy link
Collaborator

@pingyu pingyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM~

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Aug 28, 2025
@pingyu
Copy link
Collaborator

pingyu commented Aug 28, 2025

cc @iosmanthus

Copy link

ti-chi-bot bot commented Aug 29, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: iosmanthus, pingyu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 29, 2025
Copy link

ti-chi-bot bot commented Aug 29, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-08-28 23:38:10.151584295 +0000 UTC m=+483382.029415249: ☑️ agreed by pingyu.
  • 2025-08-29 02:04:43.393885455 +0000 UTC m=+492175.271716409: ☑️ agreed by iosmanthus.

@ti-chi-bot ti-chi-bot bot merged commit 691df4d into tikv:master Aug 29, 2025
7 checks passed
@pingyu
Copy link
Collaborator

pingyu commented Aug 29, 2025

@bkane-msft Thanks for your contribution !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved contribution This PR is from a community contributor. dco-signoff: yes Indicates the PR's author has signed the dco. first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. lgtm size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants