Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: check raftcluster nil #7054

Merged
merged 6 commits into from
Sep 11, 2023
Merged

*: check raftcluster nil #7054

merged 6 commits into from
Sep 11, 2023

Conversation

HuSharp
Copy link
Member

@HuSharp HuSharp commented Sep 7, 2023

What problem does this PR solve?

Issue Number: Close #7053

What is changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Release note

None.

@HuSharp
fix
eec4850 
Signed-off-by: husharp <jinhao.hu@pingcap.com>
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 7, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lhy1024
  • rleungx

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-triage-completed labels Sep 7, 2023
@ti-chi-bot ti-chi-bot bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 7, 2023
@HuSharp HuSharp requested review from lhy1024 and rleungx and removed request for disksing and rleungx September 7, 2023 07:45
@ti-chi-bot ti-chi-bot bot added needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. and removed do-not-merge/needs-triage-completed labels Sep 7, 2023
@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 7, 2023
@codecov
Copy link

codecov bot commented Sep 7, 2023 •
edited
Loading

Codecov Report

Merging #7054 (2f5117e) into master (d031342) will decrease coverage by 0.05%.
Report is 1 commits behind head on master.
The diff coverage is 44.44%.

❗ Current head 2f5117e differs from pull request most recent head 410c9a9. Consider uploading reports for the commit 410c9a9 to get more accurate results

@@            Coverage Diff             @@
##           master    #7054      +/-   ##
==========================================
- Coverage   74.41%   74.36%   -0.05%     
==========================================
  Files         436      436              
  Lines       46440    46460      +20     
==========================================
- Hits        34558    34552       -6     
- Misses       8858     8874      +16     
- Partials     3024     3034      +10
Flag Coverage Δ
unittests 74.36% <44.44%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

lhy1024
lhy1024 reviewed Sep 7, 2023
View reviewed changes
Copy link
Contributor

@lhy1024 lhy1024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to add some tests? Which branches do we need to pick?

@HuSharp
Copy link
Member Author

HuSharp commented Sep 7, 2023 •
edited
Loading

Which branches do we need to pick?

I think it need to pick to the branch which we supported

@HuSharp
add test
539d4dc 
Signed-off-by: husharp <ihusharp@gmail.com>
@HuSharp
Copy link
Member Author

HuSharp commented Sep 8, 2023

After reviewing the code, I found that there is a middleware that checks raftCluster #1908
I am not sure why this panic is occurring... :(

@rleungx
Copy link
Member

rleungx commented Sep 8, 2023

After reviewing the code, I found that there is a middleware that checks raftCluster #1908 I am not sure why this panic is occurring... :(

Maybe you need to use getCluster(r)?

@HuSharp
address comment
79ddabf 
Signed-off-by: husharp <ihusharp@gmail.com>
@HuSharp
Copy link
Member Author

HuSharp commented Sep 8, 2023

After reviewing the code, I found that there is a middleware that checks raftCluster #1908 I am not sure why this panic is occurring... :(

Maybe you need to use getCluster(r)?

get it

@ti-chi-bot ti-chi-bot bot added the status/LGT2 Indicates that a PR has LGTM 2. label Sep 11, 2023
@HuSharp
Copy link
Member Author

HuSharp commented Sep 11, 2023

Can you leave a merge label @rleungx @lhy1024 thx! :)

@lhy1024
Copy link
Contributor

lhy1024 commented Sep 11, 2023

/merge

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 11, 2023

@lhy1024: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 11, 2023

This pull request has been accepted and is ready to merge.

Commit hash: 2f5117e

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 11, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 11, 2023

@HuSharp: Your PR was out of date, I have automatically updated it for you.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot bot merged commit d03f485 into tikv:master Sep 11, 2023
22 checks passed
@ti-chi-bot ti-chi-bot mentioned this pull request Sep 11, 2023
Closed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-5.3: #7067.

ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this pull request Sep 11, 2023
@HuSharp @ti-chi-bot
This is an automated cherry-pick of tikv#7054
8b1e141 
close tikv#7053

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-5.4: #7068.

ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this pull request Sep 11, 2023
@HuSharp @ti-chi-bot
This is an automated cherry-pick of tikv#7054
2a303e5 
close tikv#7053

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
This was referenced Sep 11, 2023
Merged
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.1: #7069.

ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this pull request Sep 11, 2023
@HuSharp @ti-chi-bot
This is an automated cherry-pick of tikv#7054
334a714 
close tikv#7053

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Sep 11, 2023
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #7070.

ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this pull request Sep 11, 2023
@HuSharp @ti-chi-bot
This is an automated cherry-pick of tikv#7054
df236db 
close tikv#7053

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Sep 11, 2023
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #7071.

ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this pull request Sep 11, 2023
@HuSharp @ti-chi-bot
This is an automated cherry-pick of tikv#7054
e238f15 
close tikv#7053

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
ti-chi-bot bot pushed a commit that referenced this pull request Sep 11, 2023
@ti-chi-bot @HuSharp
*: check raftcluster nil (#7054) (#7070)
094ce3c 
close #7053

Signed-off-by: husharp <ihusharp@gmail.com>

Co-authored-by: husharp <ihusharp@gmail.com>
@HuSharp HuSharp deleted the fix_cluster_pinic branch September 14, 2023 12:51
ti-chi-bot bot pushed a commit that referenced this pull request Sep 19, 2023
@ti-chi-bot @HuSharp
*: check raftcluster nil (#7054) (#7071)
115052d 
close #7053

Signed-off-by: husharp <jinhao.hu@pingcap.com>

Co-authored-by: husharp <jinhao.hu@pingcap.com>
ti-chi-bot bot pushed a commit that referenced this pull request Sep 19, 2023
@ti-chi-bot @HuSharp
*: check raftcluster nil (#7054) (#7069)
f4d1cb7 
close #7053

Signed-off-by: husharp <jinhao.hu@pingcap.com>

Co-authored-by: husharp <jinhao.hu@pingcap.com>
ti-chi-bot bot pushed a commit that referenced this pull request Sep 14, 2024
@ti-chi-bot @HuSharp
*: check raftcluster nil (#7054) (#7068)
9365b94 
close #7053

Signed-off-by: husharp <ihusharp@gmail.com>

Co-authored-by: husharp <ihusharp@gmail.com>
Co-authored-by: Hu# <ihusharp@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lhy1024 lhy1024 lhy1024 approved these changes

@rleungx rleungx rleungx approved these changes

@JmPotato JmPotato Awaiting requested review from JmPotato

Assignees
No one assigned
Labels
needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PD may panic when exit
4 participants
@HuSharp @rleungx @lhy1024 @ti-chi-bot