Skip to content

*: check raftcluster nil (#7054)#7070

Merged
ti-chi-bot[bot] merged 1 commit intotikv:release-6.5from
ti-chi-bot:cherry-pick-7054-to-release-6.5
Sep 11, 2023
Merged

*: check raftcluster nil (#7054)#7070
ti-chi-bot[bot] merged 1 commit intotikv:release-6.5from
ti-chi-bot:cherry-pick-7054-to-release-6.5

Conversation

@ti-chi-bot
Copy link
Copy Markdown
Member

This is an automated cherry-pick of #7054

What problem does this PR solve?

Issue Number: Close #7053

What is changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Release note

None.

@ti-chi-bot
Copy link
Copy Markdown
Contributor

ti-chi-bot Bot commented Sep 11, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • HuSharp
  • lhy1024

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR. labels Sep 11, 2023
@ti-chi-bot ti-chi-bot Bot requested review from HunDunDM and disksing September 11, 2023 07:45
Signed-off-by: husharp <ihusharp@gmail.com>
@HuSharp HuSharp force-pushed the cherry-pick-7054-to-release-6.5 branch from df236db to 939707e Compare September 11, 2023 10:27
@HuSharp HuSharp requested review from HuSharp, lhy1024 and rleungx and removed request for HunDunDM and disksing September 11, 2023 10:27
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Sep 11, 2023
@ti-chi-bot ti-chi-bot Bot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 11, 2023
@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 11, 2023

Codecov Report

Patch coverage is 40.81% of modified lines.

Files Changed Coverage
server/cluster/cluster.go 0.00%
server/grpc_service.go 0.00%
server/server.go 45.45%
server/api/min_resolved_ts.go 50.00%
server/handler.go 50.00%

📢 Thoughts on this report? Let us know!.

@ti-chi-bot ti-chi-bot Bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 11, 2023
@lhy1024
Copy link
Copy Markdown
Contributor

lhy1024 commented Sep 11, 2023

/merge

@ti-chi-bot
Copy link
Copy Markdown
Contributor

ti-chi-bot Bot commented Sep 11, 2023

@lhy1024: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Copy Markdown
Contributor

ti-chi-bot Bot commented Sep 11, 2023

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 939707e

@ti-chi-bot ti-chi-bot Bot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 11, 2023
@ti-chi-bot ti-chi-bot Bot merged commit 094ce3c into tikv:release-6.5 Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cherry-pick-approved Cherry pick PR approved by release team. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants