-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update protobuf requirement from 2.0 to 3.1 #136
Conversation
0053757
to
bb61879
Compare
@dependabot rebase |
Updates the requirements on [protobuf](https://github.com/stepancheg/rust-protobuf) to permit the latest version. - [Release notes](https://github.com/stepancheg/rust-protobuf/releases) - [Changelog](https://github.com/stepancheg/rust-protobuf/blob/master/CHANGELOG.md) - [Commits](stepancheg/rust-protobuf@v2.0.0...v3.1.0) --- updated-dependencies: - dependency-name: protobuf dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
bb61879
to
7019336
Compare
@YangKeao Are there other blocks from this PR that get merged? I'm willing to fix the API breaks. |
@Xuanwo The 3.x version rust-protobuf seems not to be used by many users. I'm afraid it will become a huge break for existing user. See https://crates.io/crates/protobuf "Downloads over the last 90 days" |
Let's close this PR until we think |
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting If you change your mind, just re-open this PR and I'll resolve any conflicts on it. |
Updates the requirements on protobuf to permit the latest version.
Changelog
Sourced from protobuf's changelog.
Commits
c65c7d5
Bump version to 3.1.070cd66e
Move clear_field reflection test7f70813
Reflection clear_field testsd4aa230
Allow clearing field via reflectiona9ca7ed
Bump version to 3.1.0-pre09c9c62
Bump version to 3.0.3276a3cf
set supported features (#626)3585c2c
Bump version to 3.0.26ff997e
Fix generated mod.rs to pass cargo fmt -- --check2bf4397
Erase changelogDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)