Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update protobuf requirement from 2.0 to 3.1 #136

Closed
wants to merge 1 commit into from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jun 22, 2022

Updates the requirements on protobuf to permit the latest version.

Changelog

Sourced from protobuf's changelog.

[3.1.0] - 2022-06-22

[3.0.3] - 2022-05-31

[3.0.2] - 2022-05-06

[3.0.1] - 2022-05-01

  • More up to date readme.

[3.0.0] - 2022-05-01

  • New stable version released.

Before version 3

Changelog before version 3

Commits

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies Pull requests that update a dependency file rust Pull requests that update Rust code labels Jun 22, 2022
@dependabot dependabot bot force-pushed the dependabot/cargo/protobuf-3.1 branch from 0053757 to bb61879 Compare June 23, 2022 08:00
@Xuanwo
Copy link
Member

Xuanwo commented Jun 25, 2022

@dependabot rebase

Updates the requirements on [protobuf](https://github.com/stepancheg/rust-protobuf) to permit the latest version.
- [Release notes](https://github.com/stepancheg/rust-protobuf/releases)
- [Changelog](https://github.com/stepancheg/rust-protobuf/blob/master/CHANGELOG.md)
- [Commits](stepancheg/rust-protobuf@v2.0.0...v3.1.0)

---
updated-dependencies:
- dependency-name: protobuf
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/cargo/protobuf-3.1 branch from bb61879 to 7019336 Compare June 25, 2022 12:43
@Xuanwo
Copy link
Member

Xuanwo commented Jun 27, 2022

@YangKeao Are there other blocks from this PR that get merged? I'm willing to fix the API breaks.

@YangKeao
Copy link
Member

YangKeao commented Jun 27, 2022

@YangKeao Are there other blocks from this PR that get merged? I'm willing to fix the API breaks.

@Xuanwo The 3.x version rust-protobuf seems not to be used by many users. I'm afraid it will become a huge break for existing user.

See https://crates.io/crates/protobuf "Downloads over the last 90 days"

@Xuanwo
Copy link
Member

Xuanwo commented Jun 27, 2022

Let's close this PR until we think protobuf v3 is mature enough.

@Xuanwo Xuanwo closed this Jun 27, 2022
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Jun 27, 2022

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot bot deleted the dependabot/cargo/protobuf-3.1 branch June 27, 2022 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file rust Pull requests that update Rust code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants