Add compaction order check and data block cache check #195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Connor1996 <zbk602423539@gmail.com>
yiwu-arbug
reviewed
Sep 28, 2020
|
btw CI looks like real failure. |
yiwu-arbug
reviewed
Sep 29, 2020
yiwu-arbug
reviewed
Sep 29, 2020
| @@ -2959,10 +2978,10 @@ bool BlockBasedTableIterator<TBlockIter, TValue>::InitDataBlock() { | |||
| /*get_context=*/nullptr, &lookup_context_, s, prefetch_buffer_.get(), | |||
| /*for_compaction=*/lookup_context_.caller == | |||
| TableReaderCaller::kCompaction); | |||
| if (!block_iter_.Valid()) { | |||
| block_iter_points_to_real_block_ = true; | |||
There was a problem hiding this comment.
why reset block_iter_points_to_real_block_?
There was a problem hiding this comment.
we invalidate the block iter when corruption detected. If not set block_iter_points_to_real_block_ = true, upper place will check the status of index iter instead of block iter.
yiwu-arbug
reviewed
Sep 29, 2020
|
CI is still failing. |
|
cherry-pick 3.0 and 4.0? |
|
@yiwu-arbug Not sure if it would be false positive. Let's enable it in master for a while and cherry pick to 4.0 later? |
yiwu-arbug
pushed a commit
to tikv/rust-rocksdb
that referenced
this pull request
Oct 11, 2020
update rocksdb to include tikv/rocksdb#195 for master Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
Connor1996
added a commit
to Connor1996/rocksdb
that referenced
this pull request
Nov 11, 2020
* add compaction order check and data block cache check Signed-off-by: Connor1996 <zbk602423539@gmail.com>
yiwu-arbug
pushed a commit
that referenced
this pull request
Nov 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add checks to avoid wrongly mapping block cache populating
getanditeratorfurther., for more information of the wrongly mapping block cache, see facebook#7405Add check logic: