Return sequence number of writes #292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: 5kbpers <hustmh@gmail.com>
tabokie
reviewed
Jun 24, 2022
5kbpers
commented
Jun 24, 2022
| @@ -379,7 +380,10 @@ class DB { | |||
| // options.sync=true. | |||
| // Returns OK on success, non-OK on failure. | |||
| // Note: consider setting options.sync = true. | |||
| virtual Status Write(const WriteOptions& options, WriteBatch* updates) = 0; | |||
| virtual Status Write(const WriteOptions& options, WriteBatch* updates, uint64_t* seq) = 0; | |||
| virtual Status Write(const WriteOptions& options, WriteBatch* updates) { | |||
There was a problem hiding this comment.
@tabokie It is a polymorphism of the old interface
tabokie
approved these changes
Jun 24, 2022
Signed-off-by: 5kbpers <hustmh@gmail.com>
tabokie
approved these changes
Jun 24, 2022
|
/run-test |
tabokie
pushed a commit
to tabokie/rocksdb
that referenced
this pull request
Jun 27, 2022
* return sequence number of writes Signed-off-by: 5kbpers <hustmh@gmail.com> * fix compile error Signed-off-by: 5kbpers <hustmh@gmail.com> Signed-off-by: tabokie <xy.tao@outlook.com>
tabokie
pushed a commit
that referenced
this pull request
Jun 28, 2022
* return sequence number of writes Signed-off-by: 5kbpers <hustmh@gmail.com> * fix compile error Signed-off-by: 5kbpers <hustmh@gmail.com> Signed-off-by: tabokie <xy.tao@outlook.com>
v01dstar
pushed a commit
to v01dstar/rocksdb
that referenced
this pull request
May 29, 2024
* return sequence number of writes Signed-off-by: 5kbpers <hustmh@gmail.com> * fix compile error Signed-off-by: 5kbpers <hustmh@gmail.com> Signed-off-by: tabokie <xy.tao@outlook.com>
v01dstar
pushed a commit
to v01dstar/rocksdb
that referenced
this pull request
Oct 2, 2024
* return sequence number of writes Signed-off-by: 5kbpers <hustmh@gmail.com> * fix compile error Signed-off-by: 5kbpers <hustmh@gmail.com> Signed-off-by: tabokie <xy.tao@outlook.com> Signed-off-by: Yang Zhang <yang.zhang@pingcap.com>
v01dstar
pushed a commit
to v01dstar/rocksdb
that referenced
this pull request
Oct 2, 2024
* return sequence number of writes Signed-off-by: 5kbpers <hustmh@gmail.com> * fix compile error Signed-off-by: 5kbpers <hustmh@gmail.com> Signed-off-by: tabokie <xy.tao@outlook.com> Signed-off-by: Yang Zhang <yang.zhang@pingcap.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: 5kbpers hustmh@gmail.com