Skip to content

csharp: use the correct update time #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 6, 2020
Merged

Conversation

nicks
Copy link
Member

@nicks nicks commented Apr 6, 2020

Hello @jazzdan,

Please review the following commits I made in branch nicks/ch5991/update:

e12770b (2020-04-06 17:46:30 -0400)
csharp: use the correct update time

bd1fb33 (2020-04-06 17:29:32 -0400)
csharp: we actually need wwwroot checked into git

Code review reminders, by giving a LGTM you attest that:

  • Commits are adequately tested
  • Code is easy to understand and conforms to style guides
  • Incomplete code is marked with TODOs
  • Code is suitably instrumented with logging and metrics

@nicks nicks requested a review from jazzdan April 6, 2020 21:46
@nicks nicks force-pushed the nicks/ch5991/update branch from e12770b to 6916a34 Compare April 6, 2020 21:47
@nicks
Copy link
Member Author

nicks commented Apr 6, 2020

this makes sure that "end time" is "the time the app started", rather than "the current time"

@nicks nicks merged commit 492c568 into master Apr 6, 2020
@nicks nicks deleted the nicks/ch5991/update branch April 6, 2020 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants