helm_remote: update directory crawling to be a bit more idiomatic #573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pointed out in tilt-dev#572 to be clear, i don't think this will actually fix the bug reported there. it's likely a deeper issue. but i agree that we shouldn't be hard-coding '/' to terminate the loop Signed-off-by: Nick Santos <nick.santos@docker.com>
nicksieger
approved these changes
Apr 19, 2024
|
Worth a try, seems like it might help. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pointed out in
#572
to be clear, i don't think this will actually
fix the bug reported there. it's likely a deeper
issue. but i agree that we shouldn't be hard-coding
'/' to terminate the loop