Add Livewire validation errors #5
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Well, that is because I merged the feature without checking that the tests pass 🧠 👈 haha Thanks for this. |
|
OMG I'm an idiot. I just forced push and cleared the commits! I had a local version and have reopened it #6 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4
Couldn't quite get all the tests to work, seems like a lot of them fail because the message is now added by default, but my added test at least passes.
This uses the
on()Livewire method to listen for exceptions in a component and records the errors from the resulting ValidationExceptionAn example from testing this in the Mailcoach codebase: