Skip to content

Record inertia PUT / PATCH / DELETE requests #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 17, 2024
Merged

Record inertia PUT / PATCH / DELETE requests #9

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
564507c
allow Inertia 303 redirects
stevethomas May 16, 2024
974f239
wip
stevethomas May 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Recorders/ValidationErrors.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,8 +111,8 @@ protected function parseValidationErrors(LivewireValidationError|RequestHandled
protected function parseSessionValidationErrors(Request $request, SymfonyResponse $response): ?Collection
{
if (
$response->getStatusCode() !== 302 ||
! $request->hasSession() ||
! in_array($response->getStatusCode(), [302, 303]) ||
! ($errors = $request->session()->get('errors', null)) instanceof ViewErrorBag
) {
return null;
Expand Down
19 changes: 19 additions & 0 deletions tests/RecorderTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
use function Pest\Laravel\get;
use function Pest\Laravel\post;
use function Pest\Laravel\postJson;
use function Pest\Laravel\put;

beforeEach(function () {
Config::set('pulse.ingest.trim.lottery', [1, 1]);
Expand Down Expand Up @@ -338,6 +339,24 @@
expect($aggregates->pluck('value')->every(fn ($value) => $value == 1.0))->toBe(true);
});

it('captures inertia validation non post errors', function () {
Config::set('pulse.recorders.'.ValidationErrors::class.'.capture_messages', false);
Route::put('settings', fn () => Request::validate([
'email' => 'required',
]))->middleware(['web', InertiaMiddleware::class]);

$response = put('settings', [], ['X-Inertia' => '1']);

$response->assertStatus(303);
$entries = Pulse::ignore(fn () => DB::table('pulse_entries')->whereType('validation_error')->get());
expect($entries)->toHaveCount(1);
expect($entries[0]->key)->toBe('["PUT","\/settings","Closure","default","email"]');
$aggregates = Pulse::ignore(fn () => DB::table('pulse_aggregates')->whereType('validation_error')->orderBy('period')->get());
expect($aggregates->pluck('key')->all())->toBe(array_fill(0, 4, '["PUT","\/settings","Closure","default","email"]'));
expect($aggregates->pluck('aggregate')->all())->toBe(array_fill(0, 4, 'count'));
expect($aggregates->pluck('value')->every(fn ($value) => $value == 1.0))->toBe(true);
});

it('captures inertia validation errors with multiple bags', function () {
Config::set('pulse.recorders.'.ValidationErrors::class.'.capture_messages', false);
Route::post('users', function () {
Expand Down