Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changelog #3239

Closed
wants to merge 28 commits into from
Closed

Changelog #3239

wants to merge 28 commits into from

Conversation

rahilsondhi
Copy link
Contributor

Adds a new Changelog to the Docs

Copy link

github-actions bot commented Jun 7, 2024

Allow 10 minutes from last push for the staging site to build. If the link doesn't work, try using incognito mode instead. For internal reviewers, check web-documentation repo actions for staging build status. Link to build for this PR: http://docs-dev.timescale.com/docs-rahil-changelog

@rahilsondhi rahilsondhi force-pushed the rahil/changelog branch 2 times, most recently from 9bbae86 to 08e6f8c Compare June 7, 2024 20:01
Copy link
Contributor

@billy-the-fish billy-the-fish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Timescale follows the Google developer style guide. A few comments to align your cool words with the guide.

about/changelog.md Show resolved Hide resolved
about/changelog.md Outdated Show resolved Hide resolved
- [#6978](https://github.com/timescale/timescaledb/issues/6978): Fix segfault in compress_chunk with primary space partition.
- [#6993](https://github.com/timescale/timescaledb/issues/6993): Disallow hash partitioning on the primary column.

## May 2024 Update
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like that we are adding information about all products, great.

For consistency, can we stick to products rather than dates in the titles:

Timescale Cloud

May 31, 2024

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But many posts will have content that span multiple products 🤔 That's why I went with a date approach, because this post was a grab bag of stuff (two new extensions and one PopSQL improvement)

Copy link
Contributor Author

@rahilsondhi rahilsondhi Jun 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check out the titles on this page. That's the style I was going for. The idea is that it catches the user's attention, like "ohh I'm interested in the git integration, and I can see git is in the title"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm nice point, and I like their doc.

All Hex releases are all done by date. To be consistent in this page, you need to change the TimescaleDB 2.15.2 header to "June 7th 2024 update" . I'd keep to specific date, patch releases can come out pretty fast.

@pallavisontakke, @fabriziomello are you ok with this?

about/changelog.md Outdated Show resolved Hide resolved
about/changelog.md Outdated Show resolved Hide resolved
about/changelog.md Outdated Show resolved Hide resolved
about/changelog.md Outdated Show resolved Hide resolved
about/changelog.md Outdated Show resolved Hide resolved
about/page-index/page-index.js Outdated Show resolved Hide resolved
about/changelog.md Outdated Show resolved Hide resolved
@shahriarpshuvo
Copy link
Contributor

Added a PR on web-documentation repo:
https://github.com/timescale/web-documentation/pull/712
This need to merge first to see the reflection.
image (1)

Copy link
Contributor

@billy-the-fish billy-the-fish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes, they look great. Nearly there.

about/changelog.md Outdated Show resolved Hide resolved
about/changelog.md Outdated Show resolved Hide resolved
about/changelog.md Outdated Show resolved Hide resolved
about/changelog.md Outdated Show resolved Hide resolved
about/changelog.md Outdated Show resolved Hide resolved
about/changelog.md Outdated Show resolved Hide resolved
about/changelog.md Outdated Show resolved Hide resolved
about/changelog.md Outdated Show resolved Hide resolved
- [#6978](https://github.com/timescale/timescaledb/issues/6978): Fix segfault in compress_chunk with primary space partition.
- [#6993](https://github.com/timescale/timescaledb/issues/6993): Disallow hash partitioning on the primary column.

## May 2024 Update
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm nice point, and I like their doc.

All Hex releases are all done by date. To be consistent in this page, you need to change the TimescaleDB 2.15.2 header to "June 7th 2024 update" . I'd keep to specific date, patch releases can come out pretty fast.

@pallavisontakke, @fabriziomello are you ok with this?

@rahilsondhi rahilsondhi marked this pull request as ready for review June 12, 2024 21:57
@rahilsondhi
Copy link
Contributor Author

See #3249

@rahilsondhi rahilsondhi deleted the rahil/changelog branch June 17, 2024 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants