-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changelog #3249
Changelog #3249
Conversation
Co-authored-by: Iain Cox <iain@timescale.com> Signed-off-by: Rahil Sondhi <rahilsondhi@gmail.com>
Signed-off-by: Rahil Sondhi <rahilsondhi@gmail.com>
Co-authored-by: Rahil Sondhi <rahilsondhi@gmail.com> Signed-off-by: Iain Cox <iain@timescale.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of thoughts for max awesomeness.
I think this is awesome! Reiterating the other comments above - generally speaking I don't think lists of TimescaleDB (or in the future pgvectorscale / pgai) features or bug fixes with links to issues makes sense. This is more of a marketing asset, so prose is best. If we can't string a sentence or two together about an item then it probably isn't newsworthy. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks awesome @billy-the-fish! 👏 I'm not too keen on merging on a Friday with no one around, so can I let you do the honors on Monday to verify it works correctly in production please?
* Add Changelog to the docs. Co-authored-by: Rahil Sondhi <rahilsondhi@gmail.com> Co-authored-by: Iain Cox <iain@timescale.com> Signed-off-by: Rahil Sondhi <rahilsondhi@gmail.com>
Description
[Short summary of why you created this PR]
Links
Fixes #[insert issue link, if any]
Writing help
For information about style and word usage, see the style guide
Review checklists
Reviewers: use this section to ensure you have checked everything before approving this PR:
Subject matter expert (SME) review checklist
Documentation team review checklist
and have they been implemented?