Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changelog #3249

Merged
merged 47 commits into from
Jun 24, 2024
Merged

Changelog #3249

merged 47 commits into from
Jun 24, 2024

Conversation

billy-the-fish
Copy link
Contributor

Description

[Short summary of why you created this PR]

Links

Fixes #[insert issue link, if any]

Writing help

For information about style and word usage, see the style guide

Review checklists

Reviewers: use this section to ensure you have checked everything before approving this PR:

Subject matter expert (SME) review checklist

  • Is the content technically accurate?
  • Is the content complete?
  • Is the content presented in a logical order?
  • Does the content use appropriate names for features and products?
  • Does the content provide relevant links to further information?

Documentation team review checklist

  • Is the content free from typos?
  • Does the content use plain English?
  • Does the content contain clear sections for concepts, tasks, and references?
  • Have any images been uploaded to the correct location, and are resolvable?
  • If the page index was updated, are redirects required
    and have they been implemented?
  • Have you checked the built version of this content?

@billy-the-fish billy-the-fish marked this pull request as draft June 13, 2024 12:54
about/changelog.md Outdated Show resolved Hide resolved
Signed-off-by: Rahil Sondhi <rahilsondhi@gmail.com>
about/changelog.md Outdated Show resolved Hide resolved
about/changelog.md Outdated Show resolved Hide resolved
@billy-the-fish billy-the-fish marked this pull request as ready for review June 14, 2024 19:34
@rahilsondhi rahilsondhi mentioned this pull request Jun 17, 2024
Copy link
Contributor Author

@billy-the-fish billy-the-fish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of thoughts for max awesomeness.

about/changelog.md Show resolved Hide resolved
about/changelog.md Outdated Show resolved Hide resolved
about/changelog.md Outdated Show resolved Hide resolved
@jamessewell
Copy link
Contributor

I think this is awesome!

Reiterating the other comments above - generally speaking I don't think lists of TimescaleDB (or in the future pgvectorscale / pgai) features or bug fixes with links to issues makes sense. This is more of a marketing asset, so prose is best. If we can't string a sentence or two together about an item then it probably isn't newsworthy.

@rahilsondhi rahilsondhi changed the title Changelog ab test Changelog Jun 18, 2024
Copy link
Contributor

@rahilsondhi rahilsondhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome @billy-the-fish! 👏 I'm not too keen on merging on a Friday with no one around, so can I let you do the honors on Monday to verify it works correctly in production please?

@billy-the-fish billy-the-fish merged commit 40613dc into latest Jun 24, 2024
3 checks passed
@billy-the-fish billy-the-fish deleted the changelog-ab-test branch June 24, 2024 07:48
billy-the-fish added a commit that referenced this pull request Aug 12, 2024
* Add Changelog to the docs. 

Co-authored-by: Rahil Sondhi <rahilsondhi@gmail.com>
Co-authored-by: Iain Cox <iain@timescale.com>
Signed-off-by: Rahil Sondhi <rahilsondhi@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants