Skip to content
This repository has been archived by the owner on Apr 2, 2024. It is now read-only.

add option to configure namespace in values.yaml #690

Merged
merged 1 commit into from
Jul 13, 2021
Merged

add option to configure namespace in values.yaml #690

merged 1 commit into from
Jul 13, 2021

Conversation

VineethReddy02
Copy link
Contributor

@VineethReddy02 VineethReddy02 commented Jul 11, 2021 •
edited
Loading

  1. Add option to configure namespace in values.yaml
  2. In helm chart template files add default namespace value as .Release.Namespace (better practice used in community helm charts)
  3. Rename connector to promscale in helm chart.
  4. Add helm chart static generation check to CI i.e. PR level tests & scheduled tests.

@VineethReddy02 VineethReddy02 force-pushed the vineeth-addnamespace-in-values-yaml branch 5 times, most recently from 229231c to 4223e9e Compare July 11, 2021 19:38
@VineethReddy02 VineethReddy02 force-pushed the vineeth-addnamespace-in-values-yaml branch from 4223e9e to 06bd9d3 Compare July 11, 2021 19:45
cevian
cevian approved these changes Jul 13, 2021
View reviewed changes
Copy link
Contributor

@cevian cevian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@VineethReddy02
Copy link
Contributor Author

bors r+

@bors
Copy link
Contributor

bors bot commented Jul 13, 2021

Build succeeded:

@bors bors bot merged commit a903f1d into timescale:master Jul 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cevian cevian cevian approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@VineethReddy02 @cevian