Add CI check for loader changes #6364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jnidzwetzki
force-pushed
the
loader_check
branch
2 times, most recently
from
f60d3b3
to
4150b1c
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6364 +/- ##
==========================================
- Coverage 86.96% 82.42% -4.54%
==========================================
Files 249 249
Lines 58006 57960 -46
Branches 12918 12899 -19
==========================================
- Hits 50443 47772 -2671
- Misses 5172 6780 +1608
- Partials 2391 3408 +1017 ☔ View full report in Codecov by Sentry. |
jnidzwetzki
force-pushed
the
loader_check
branch
2 times, most recently
from
21c7958
to
96c6c5a
Compare
|
@erimatnor, @antekresic: please review this pull request.
|
jnidzwetzki
force-pushed
the
loader_check
branch
5 times, most recently
from
6baa861
to
99d7895
Compare
jnidzwetzki
force-pushed
the
loader_check
branch
from
99d7895
to
0872beb
Compare
jnidzwetzki
force-pushed
the
loader_check
branch
from
0872beb
to
152fe03
Compare
mkindahl
approved these changes
Nov 30, 2023
src/loader/loader.c
Outdated
| // !!! LOADER CHANGE !!! | ||
|
|
||
| /* |
There was a problem hiding this comment.
Sure, it was just for illustration.
mkindahl
reviewed
Nov 30, 2023
Changes in the loader code require a restart of PostgreSQL during upgrades. This check creates awareness of these changes and allows the coordination of the update process early.
jnidzwetzki
force-pushed
the
loader_check
branch
from
152fe03
to
6011de1
Compare
antekresic
approved these changes
Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in the loader code require a restart of PostgreSQL during upgrades. This check creates awareness of these changes and allows the coordination of the update process early.
Disable-check: force-changelog-file