revise(module) to force reevaluating every expression #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry - accidental click. |
|
If you're up for the |
Merged
cstjean
force-pushed
the
pull-request/2f01000e
branch
from
2f01000
to
9c9802f
Compare
Codecov Report
@@ Coverage Diff @@
## master #41 +/- ##
==========================================
+ Coverage 83.16% 83.61% +0.45%
==========================================
Files 1 1
Lines 297 293 -4
==========================================
- Hits 247 245 -2
+ Misses 50 48 -2
Continue to review full report at Codecov.
|
|
Thanks a bunch! The OSX tests routinely fail at the "cleanup" step. I don't suppose you can reproduce that yourself, can you? If so, does adding a sleep or something fix it? |
|
I've seen it a few times, I'll try to fix it. |
This was referenced Oct 8, 2017
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested in #33 (comment)
Issues:
revise(module)as a verb, but it's not entirely obvious what it's going to do.forcerevise(module)?parse_pkg_files, which seems a tad wasteful given that those files were already parsed. We could maintainmodule2files.revise(module)triggers a lot of redefinition warnings. In ClobberingReload I use this code. We could move overscrub_stderrto Revise.jlThis is a work-around for #20 and #31, I'll leave you to decide if you want to close these issues.