Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add programmatic access #59

Merged
merged 1 commit into from
Aug 22, 2022
Merged

add programmatic access #59

merged 1 commit into from
Aug 22, 2022

Conversation

zvictor
Copy link
Contributor

@zvictor zvictor commented Aug 17, 2022

Programmatic access makes it easier to control processes in other libraries, such as here.


I don't know why github is showing such an aggressive diff for this PR. I just changed the indentation in most of the lines. I definitely didn't rewrite the whole thing 😅

That's what I have actually done (partial):
image

@zvictor
Copy link
Contributor Author

zvictor commented Aug 17, 2022

@timqian please let me know if there is any way to improve this PR.

As I mentioned, I don't know why the diff looks so bad in Github. You can check the file at https://github.com/zvictor/gql-generator/blob/master/index.js to confirm that I didn't change any of the logic other than wrap the main logic in a function (and pretty much nothing else).

I would like to push more PRs to this project still today, but I would like to wait for a confirmation on this one here first 😊

@zvictor zvictor mentioned this pull request Aug 17, 2022
@timqian
Copy link
Owner

timqian commented Aug 22, 2022

@zvictor Thanks for the PR.

As I mentioned, I don't know why the diff looks so bad in Github.

I guess we can not do much on this. When the indentation of a line changes, git thinks that line is changed

@timqian timqian merged commit ab7c7da into timqian:master Aug 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants