Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add shadowDom support #168

Merged
merged 6 commits into from
Jun 24, 2022
Merged

add shadowDom support #168

merged 6 commits into from
Jun 24, 2022

Conversation

jogibear9988
Copy link
Contributor

No description provided.

@reppners
Copy link
Collaborator

Thanks for bringing this up and providing your code and experience with shadow DOM back to the community!

Seems not much of a risk factor to get this into the next version (I'm thinking the next version should bump the major just to be safe and not break anyone).

If you are able to add a custom element to the demo that would be awesome. As simple as it can get, maybe adding just one item at the top list of items in the demo is sufficient to give me a sample for testing/playing.

@jogibear9988
Copy link
Contributor Author

I tried to work on a demo, but your demo project does not work on my system.
I did "npm run start" and got this errors:

image

@reppners
Copy link
Collaborator

Can you rebase on latest master and perform a fresh npm install? I've updated all the devDependencies to latest versions and I'm seeing no issues with latest Chrome.

@jogibear9988
Copy link
Contributor Author

@reppners
if now added a web component to the sample.
You needed an additional fix, so the pointer-events in all elements of the shadow dom are disabled.
This was not needed in my case, cause I don't use the "copied element" during drag, and also it is not below mouse cursor

@jogibear9988
Copy link
Contributor Author

@reppners
any news?

@danziv
Copy link

danziv commented Jun 23, 2022

@reppners can this be merged?

@reppners reppners merged commit 1345368 into timruffles:master Jun 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants