Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to Python 3 #31

Merged
merged 3 commits into from
May 4, 2019
Merged

Upgrade to Python 3 #31

merged 3 commits into from
May 4, 2019

Conversation

pp3345
Copy link
Contributor

@pp3345 pp3345 commented May 1, 2019

This branch upgrades the project to Python 3.7 and removes compatibility for Python 2.

mithro
mithro approved these changes May 1, 2019
View reviewed changes
Copy link
Member

@mithro mithro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@mithro
Copy link
Member

mithro commented May 1, 2019 

0.13s$ coverage run --source=edid_parser edid_parser/tests.py
Traceback (most recent call last):
  File "edid_parser/tests.py", line 6, in <module>
    from .edid_parser import (EDIDParser, EDIDParsingError, DisplayType,
ModuleNotFoundError: No module named '__main__.edid_parser'; '__main__' is not a package
The command "coverage run --source=edid_parser edid_parser/tests.py" exited with 1.

@pp3345
Copy link
Contributor Author

pp3345 commented May 1, 2019

Yeah, looking into that now.

@pp3345 pp3345 force-pushed the py3 branch 2 times, most recently from dfa24b2 to bd9182d Compare May 1, 2019 21:59
@pp3345 pp3345 changed the title Upgrade to Python 3 WIP: Upgrade to Python 3 May 1, 2019
@mithro
Copy link
Member

mithro commented May 1, 2019 

0.08s$ pycodestyle --statistics --exclude=wsgi.py *.py
path.py:2:16: W292 no newline at end of file
1       W292 no newline at end of file
The command "pycodestyle --statistics --exclude=wsgi.py *.py" exited with 1.

@pp3345
Run edid_parser tests with correct path
92a2102 
Not entirely sure why this is required, but oh well...
@pp3345 pp3345 changed the title WIP: Upgrade to Python 3 Upgrade to Python 3 May 4, 2019
@pp3345
Copy link
Contributor Author

pp3345 commented May 4, 2019

Okay, everything is green now.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 99.051% when pulling 92a2102 on pp3345:py3 into e1138d2 on timvideos:master.

@mithro mithro merged commit 624b056 into timvideos:master May 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mithro mithro mithro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pp3345 @mithro @coveralls