Update all the things! #125

mmlb · 2022-05-10T20:31:39Z

Description

Updates all the things that we use in hook (except the kernel). This sort of started because of #105 where tests failed because of latest make lint which wanted go1.17 and we've been wanting to update to that anyway and well here we are.

Why is this needed

I was rebasing #105 and noticed that I had a bunch of non-Makefile stuff there including some stuff I hadn't pushed yet (go update). So I broke it out to this PR instead.

How Has This Been Tested?

make lint works, and make dev does too.

How are existing users impacted? What migration steps/scripts do we need?

Nicer looking code.

Signed-off-by: Manuel Mendez <github@i.m.mmlb.dev>

Mostly just for visibility into timing. Signed-off-by: Manuel Mendez <github@i.m.mmlb.dev>

Signed-off-by: Manuel Mendez <github@i.m.mmlb.dev>

I couldn't figure out a max line length and so decided one-sentence-per-line. Signed-off-by: Manuel Mendez <github@i.m.mmlb.dev>

sonatype-lift · 2022-05-10T20:33:11Z

tink-docker/main.go

@@ -130,6 +130,8 @@ func downloadFile(filepath string, url string) error {
 		if err == nil {
 			break
 		}
+		resp.Body.Close()


G104: Errors unhandled.

(at-me in a reply with help or ignore)

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-05-10T21:52:19Z

tink-docker/main.go

@@ -130,6 +130,8 @@ func downloadFile(filepath string, url string) error {
 		if err == nil {
 			break
 		}
+		resp.Body.Close()


G104: Errors unhandled.

(at-me in a reply with help or ignore)

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-05-11T15:12:36Z

tink-docker/main.go

@@ -130,6 +130,8 @@ func downloadFile(filepath string, url string) error {
 		if err == nil {
 			break
 		}
+		resp.Body.Close()


G104: Errors unhandled.

(at-me in a reply with help or ignore)

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-05-11T17:05:49Z

tink-docker/main.go

@@ -130,6 +130,8 @@ func downloadFile(filepath string, url string) error {
 		if err == nil {
 			break
 		}
+		resp.Body.Close()


G104: Errors unhandled.

(at-me in a reply with help or ignore)

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-05-11T17:52:24Z

tink-docker/main.go

@@ -130,6 +130,8 @@ func downloadFile(filepath string, url string) error {
 		if err == nil {
 			break
 		}
+		resp.Body.Close()


G104: Errors unhandled.

(at-me in a reply with help or ignore)

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

ScottGarman · 2022-05-16T17:15:30Z

README.md

+[osie]: https://github.com/tinkebell/osie
+[sandbox]: https://github.com/tinkerbell/sandbox
+[specification]: https://github.com/linuxkit/linuxkit/blob/master/docs/yaml.md
+[tinkerbe]: https://tinkerbell.org


should be fixed now @ScottGarman, ptal

sonatype-lift · 2022-05-16T17:16:04Z

tink-docker/main.go

@@ -130,6 +130,8 @@ func downloadFile(filepath string, url string) error {
 		if err == nil {
 			break
 		}
+		resp.Body.Close()


G104: Errors unhandled.

(at-me in a reply with help or ignore)

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

Avoids repitition and long lines. Signed-off-by: Manuel Mendez <github@i.m.mmlb.dev>

Signed-off-by: Manuel Mendez <github@i.m.mmlb.dev>

With fixes from tinkerbell/lint-install#40 applied manually. Signed-off-by: Manuel Mendez <github@i.m.mmlb.dev>

Still builds, so

I guess...? Signed-off-by: Manuel Mendez <github@i.m.mmlb.dev>

Signed-off-by: Manuel Mendez <github@i.m.mmlb.dev>

sonatype-lift · 2022-05-16T17:28:23Z

tink-docker/main.go

@@ -130,6 +130,8 @@ func downloadFile(filepath string, url string) error {
 		if err == nil {
 			break
 		}
+		resp.Body.Close()


G104: Errors unhandled.

(at-me in a reply with help or ignore)

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

mmlb and others added 6 commits May 10, 2022 16:29

nix: Add missing deps so --pure works

ca8abc0

Signed-off-by: Manuel Mendez <github@i.m.mmlb.dev>

nix: nixfmtize

e9eb306

Signed-off-by: Manuel Mendez <github@i.m.mmlb.dev>

ci: fetch nix deps on their own

870466a

Mostly just for visibility into timing. Signed-off-by: Manuel Mendez <github@i.m.mmlb.dev>

Update to go 1.17

9d07805

Signed-off-by: Manuel Mendez <github@i.m.mmlb.dev>

Move linter stuff to lint.mk

275e2a9

Signed-off-by: Manuel Mendez <github@i.m.mmlb.dev>

README: reflow to one-sentence-per-line

db44086

I couldn't figure out a max line length and so decided one-sentence-per-line. Signed-off-by: Manuel Mendez <github@i.m.mmlb.dev>

mmlb force-pushed the update-all-the-things branch from 8727cc6 to 926fdda Compare May 10, 2022 20:31

sonatype-lift bot reviewed May 10, 2022

View reviewed changes

mmlb force-pushed the update-all-the-things branch from 926fdda to 1593745 Compare May 10, 2022 21:50

mmlb mentioned this pull request May 10, 2022

Rework the Makefile so its not racy #105

Merged

3 tasks

sonatype-lift bot reviewed May 10, 2022

View reviewed changes

sonatype-lift bot reviewed May 11, 2022

View reviewed changes

mmlb requested a review from thebsdbox May 11, 2022 16:06

mmlb force-pushed the update-all-the-things branch from 8bad1d4 to 8974c12 Compare May 11, 2022 17:01

sonatype-lift bot reviewed May 11, 2022

View reviewed changes

mmlb force-pushed the update-all-the-things branch from 8974c12 to dd4f190 Compare May 11, 2022 17:50

sonatype-lift bot reviewed May 11, 2022

View reviewed changes

mmlb force-pushed the update-all-the-things branch from dd4f190 to 248c0c6 Compare May 16, 2022 17:11

ScottGarman reviewed May 16, 2022

View reviewed changes

sonatype-lift bot reviewed May 16, 2022

View reviewed changes

mmlb and others added 5 commits May 16, 2022 13:25

README: use ref style links

25fad85

Avoids repitition and long lines. Signed-off-by: Manuel Mendez <github@i.m.mmlb.dev>

Prettierify all the things

74ae998

Signed-off-by: Manuel Mendez <github@i.m.mmlb.dev>

ci: Enforce prettier formatting

50bf758

Signed-off-by: Manuel Mendez <github@i.m.mmlb.dev>

Add GOBIN and BIN handling to .envrc

fb96bf4

Signed-off-by: Manuel Mendez <github@i.m.mmlb.dev>

Fix things that upcoming lint-install linters will complain about

4ca1a3a

Signed-off-by: Manuel Mendez <github@i.m.mmlb.dev>

mmlb added 4 commits May 16, 2022 13:25

Run latest lint-install to generate new files

4ca3ab7

With fixes from tinkerbell/lint-install#40 applied manually. Signed-off-by: Manuel Mendez <github@i.m.mmlb.dev>

nix: Update linuxkit revision to latest master commit

48105ef

Still builds, so I guess...? Signed-off-by: Manuel Mendez <github@i.m.mmlb.dev>

tink-docker: Update dind image

8ad94ce

Signed-off-by: Manuel Mendez <github@i.m.mmlb.dev>

ci: Update all the github actions

f8e1ab4

Signed-off-by: Manuel Mendez <github@i.m.mmlb.dev>

mmlb force-pushed the update-all-the-things branch from 248c0c6 to f8e1ab4 Compare May 16, 2022 17:26

mmlb requested a review from ScottGarman May 16, 2022 17:26

sonatype-lift bot reviewed May 16, 2022

View reviewed changes

ScottGarman approved these changes May 16, 2022

View reviewed changes

mmlb removed the request for review from thebsdbox May 16, 2022 17:37

mmlb added the ready-to-merge Signal to Mergify to merge the PR. label May 16, 2022

mergify bot merged commit 029ef8f into tinkerbell:main May 16, 2022

mmlb deleted the update-all-the-things branch May 16, 2022 17:43

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update all the things! #125

Update all the things! #125

mmlb commented May 10, 2022

sonatype-lift bot May 10, 2022

sonatype-lift bot May 10, 2022

sonatype-lift bot May 11, 2022

sonatype-lift bot May 11, 2022

sonatype-lift bot May 11, 2022

ScottGarman May 16, 2022

mmlb May 16, 2022

mmlb May 16, 2022

sonatype-lift bot May 16, 2022

sonatype-lift bot May 16, 2022

Update all the things! #125

Update all the things! #125

Conversation

mmlb commented May 10, 2022

Description

Why is this needed

How Has This Been Tested?

How are existing users impacted? What migration steps/scripts do we need?

sonatype-lift bot May 10, 2022

Choose a reason for hiding this comment

sonatype-lift bot May 10, 2022

Choose a reason for hiding this comment

sonatype-lift bot May 11, 2022

Choose a reason for hiding this comment

sonatype-lift bot May 11, 2022

Choose a reason for hiding this comment

sonatype-lift bot May 11, 2022

Choose a reason for hiding this comment

ScottGarman May 16, 2022

Choose a reason for hiding this comment

mmlb May 16, 2022

Choose a reason for hiding this comment

mmlb May 16, 2022

Choose a reason for hiding this comment

sonatype-lift bot May 16, 2022

Choose a reason for hiding this comment

sonatype-lift bot May 16, 2022

Choose a reason for hiding this comment