-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update all the things! #125
Conversation
Signed-off-by: Manuel Mendez <github@i.m.mmlb.dev>
Signed-off-by: Manuel Mendez <github@i.m.mmlb.dev>
Mostly just for visibility into timing. Signed-off-by: Manuel Mendez <github@i.m.mmlb.dev>
Signed-off-by: Manuel Mendez <github@i.m.mmlb.dev>
Signed-off-by: Manuel Mendez <github@i.m.mmlb.dev>
I couldn't figure out a max line length and so decided one-sentence-per-line. Signed-off-by: Manuel Mendez <github@i.m.mmlb.dev>
8727cc6
to
926fdda
Compare
@@ -130,6 +130,8 @@ func downloadFile(filepath string, url string) error { | |||
if err == nil { | |||
break | |||
} | |||
resp.Body.Close() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
G104: Errors unhandled.
(at-me in a reply with help
or ignore
)
Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
926fdda
to
1593745
Compare
@@ -130,6 +130,8 @@ func downloadFile(filepath string, url string) error { | |||
if err == nil { | |||
break | |||
} | |||
resp.Body.Close() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
G104: Errors unhandled.
(at-me in a reply with help
or ignore
)
Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
@@ -130,6 +130,8 @@ func downloadFile(filepath string, url string) error { | |||
if err == nil { | |||
break | |||
} | |||
resp.Body.Close() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
G104: Errors unhandled.
(at-me in a reply with help
or ignore
)
Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
8bad1d4
to
8974c12
Compare
@@ -130,6 +130,8 @@ func downloadFile(filepath string, url string) error { | |||
if err == nil { | |||
break | |||
} | |||
resp.Body.Close() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
G104: Errors unhandled.
(at-me in a reply with help
or ignore
)
Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
8974c12
to
dd4f190
Compare
@@ -130,6 +130,8 @@ func downloadFile(filepath string, url string) error { | |||
if err == nil { | |||
break | |||
} | |||
resp.Body.Close() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
G104: Errors unhandled.
(at-me in a reply with help
or ignore
)
Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
dd4f190
to
248c0c6
Compare
README.md
Outdated
[osie]: https://github.com/tinkebell/osie | ||
[sandbox]: https://github.com/tinkerbell/sandbox | ||
[specification]: https://github.com/linuxkit/linuxkit/blob/master/docs/yaml.md | ||
[tinkerbe]: https://tinkerbell.org |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
indeed!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be fixed now @ScottGarman, ptal
@@ -130,6 +130,8 @@ func downloadFile(filepath string, url string) error { | |||
if err == nil { | |||
break | |||
} | |||
resp.Body.Close() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
G104: Errors unhandled.
(at-me in a reply with help
or ignore
)
Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
Avoids repitition and long lines. Signed-off-by: Manuel Mendez <github@i.m.mmlb.dev>
Signed-off-by: Manuel Mendez <github@i.m.mmlb.dev>
Signed-off-by: Manuel Mendez <github@i.m.mmlb.dev>
Signed-off-by: Manuel Mendez <github@i.m.mmlb.dev>
Signed-off-by: Manuel Mendez <github@i.m.mmlb.dev>
With fixes from tinkerbell/lint-install#40 applied manually. Signed-off-by: Manuel Mendez <github@i.m.mmlb.dev>
Still builds, so I guess...? Signed-off-by: Manuel Mendez <github@i.m.mmlb.dev>
Signed-off-by: Manuel Mendez <github@i.m.mmlb.dev>
Signed-off-by: Manuel Mendez <github@i.m.mmlb.dev>
248c0c6
to
f8e1ab4
Compare
@@ -130,6 +130,8 @@ func downloadFile(filepath string, url string) error { | |||
if err == nil { | |||
break | |||
} | |||
resp.Body.Close() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
G104: Errors unhandled.
(at-me in a reply with help
or ignore
)
Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
Description
Updates all the things that we use in hook (except the kernel). This sort of started because of #105 where tests failed because of latest
make lint
which wanted go1.17 and we've been wanting to update to that anyway and well here we are.Why is this needed
I was rebasing #105 and noticed that I had a bunch of non-Makefile stuff there including some stuff I hadn't pushed yet (go update). So I broke it out to this PR instead.
How Has This Been Tested?
make lint
works, andmake dev
does too.How are existing users impacted? What migration steps/scripts do we need?
Nicer looking code.