Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add flag to set TFTP block size. #368

Closed
0megam opened this issue Nov 6, 2023 · 1 comment · Fixed by #369
Closed

Add flag to set TFTP block size. #368

0megam opened this issue Nov 6, 2023 · 1 comment · Fixed by #369

Comments

@0megam
Copy link

0megam commented Nov 6, 2023

Sometimes increase of TFTP block size helps to speed up TFTP transfer.
It will be grate to have such flag in SMEE.
If understand correctly it's already supported by a library that SMEE is using: https://github.com/tinkerbell/ipxedust/blob/main/cmd.go#L117C2-L117C2
Thanks.
@jacobweinstock jacobweinstock mentioned this issue Nov 6, 2023
Merged
3 tasks
@mergify mergify bot closed this as completed in #369 Nov 6, 2023
mergify bot added a commit that referenced this issue Nov 6, 2023
@mergify
Add TFTP blocksize flag: (#369)
bbd2b14 
## Description


Allows customizing TFTP blocksize at runtime.

## Why is this needed



Fixes: #368 

## How Has This Been Tested?





## How are existing users impacted? What migration steps/scripts do we need?





## Checklist:

I have:

- [ ] updated the documentation and/or roadmap (if required)
- [ ] added unit or e2e tests
- [ ] provided instructions on how to upgrade
@0megam
Copy link
Author

0megam commented Nov 7, 2023 •
edited
Loading

Thank you for quick response. Works great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add TFTP blocksize flag: jacobweinstock/smee
1 participant
@0megam