Fix forecast first point in CatBoostPerSegmentModel #1010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 Deployed on https://deploy-preview-1010--etna-docs.netlify.app |
Codecov Report
@@ Coverage Diff @@
## master #1010 +/- ##
==========================================
+ Coverage 85.74% 85.79% +0.04%
==========================================
Files 162 162
Lines 8616 8616
==========================================
+ Hits 7388 7392 +4
+ Misses 1228 1224 -4
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Update changelog. |
Mr-Geekman
reviewed
Nov 24, 2022
etna/models/mixins.py
Outdated
| @@ -288,8 +288,7 @@ def _make_predictions_segment( | |||
| model: Any, segment: str, ts: TSDataset, prediction_method: Callable, **kwargs | |||
| ) -> pd.DataFrame: | |||
| """Make predictions for one segment.""" | |||
| segment_features = ts[:, segment, :] | |||
| segment_features = segment_features.droplevel("segment", axis=1) | |||
| segment_features = ts.to_pandas()[segment] | |||
There was a problem hiding this comment.
I have doubts that it will slow down all our per-segment models because conversion to_pandas will happen for each segment and it isn't free (we make a copy where).
There was a problem hiding this comment.
May be we can make this copy only once in _make_prediction and remember it.
Mr-Geekman
approved these changes
Nov 24, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting (must do checklist)
Proposed Changes
Closing issues
closes #785