Issue-1078: missed kwargs in TFT init #1084
Conversation
|
🚀 Deployed on https://deploy-preview-1084--etna-docs.netlify.app |
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## master #1084 +/- ##
==========================================
- Coverage 87.08% 86.98% -0.11%
==========================================
Files 170 170
Lines 9309 9310 +1
==========================================
- Hits 8107 8098 -9
- Misses 1202 1212 +10
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
| @@ -187,3 +187,11 @@ def test_save_load(example_tsds): | |||
| transform = _get_default_transform(horizon) | |||
| transforms = [transform] | |||
| assert_model_equals_loaded_original(model=model, ts=example_tsds, transforms=transforms, horizon=horizon) | |||
|
|
|||
|
|
|||
| def test_repr(): | |||
There was a problem hiding this comment.
Don't we want to add the same test for deep-ar? Because it can be strange that we have this test for tft, but doesn't have for deep-ar.
There was a problem hiding this comment.
I don't think so.
I've added this test because there was issue with TFT.
Otherwise we should add such tests for every representable object not only deepar - and I think it doesn't make much sense for now
Before submitting (must do checklist)
Proposed Changes
I've checked other inits. It seems TFT is the only model with such issue
Closing issues
closes #1078