Moving _check_endings call to make_future
#413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #413 +/- ##
==========================================
+ Coverage 87.09% 87.22% +0.12%
==========================================
Files 98 99 +1
Lines 4945 5002 +57
==========================================
+ Hits 4307 4363 +56
- Misses 638 639 +1
Continue to review full report at Codecov.
|
martins0n
suggested changes
Dec 24, 2021
| @@ -58,6 +59,12 @@ def ts_with_regressors(): | |||
| return TSDataset(df=TSDataset.to_dataset(df), df_exog=TSDataset.to_dataset(df_exog_all_segments), freq="D") | |||
|
|
|||
|
|
|||
| @pytest.fixture() | |||
| def ts_with_regressors_diff_endings(ts_with_regressors): | |||
There was a problem hiding this comment.
Is it not the same as in tests/conftest.py?
it's better to rename ts_diff_endings -> ts_with_regressors_diff_endings
| @@ -35,6 +35,14 @@ def ts_with_large_regressors_number(random_seed) -> TSDataset: | |||
| return ts | |||
|
|
|||
|
|
|||
| @pytest.fixture() | |||
| def ts_with_regressors_diff_endings(ts_with_large_regressors_number): | |||
There was a problem hiding this comment.
we have this fixture above or rename it if it's not the same
martins0n
approved these changes
Dec 24, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: Please do not create a Pull Request without creating an issue first.
Before submitting (must do checklist)
Type of Change
Proposed Changes
Related Issue
Closing issues
closes #399