Skip to content

Clarify the behaviour of TimeSeriesImputerTransform in case of all NaN values #427

Merged
merged 9 commits into from
Dec 29, 2021

Conversation

Mr-Geekman
Copy link
Contributor

@Mr-Geekman Mr-Geekman commented Dec 29, 2021

IMPORTANT: Please do not create a Pull Request without creating an issue first.

Before submitting (must do checklist)

  • Did you read the contribution guide?
  • Did you update the docs? We use Numpy format for all the methods and classes.
  • Did you write any new necessary tests?
  • Did you update the CHANGELOG?

Type of Change

  • Examples / docs / tutorials / contributors update
  • Bug fix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves an existing feature)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Proposed Changes

Look #339.

Related Issue

#339.

Closing issues

Closes #339.

…se of all NaN values, add tests for it, extend description of the class
@Mr-Geekman Mr-Geekman added the enhancement New feature or request label Dec 29, 2021
@Mr-Geekman Mr-Geekman self-assigned this Dec 29, 2021
@codecov-commenter
Copy link

codecov-commenter commented Dec 29, 2021

Codecov Report

Merging #427 (9d1ee74) into master (0e1f7c1) will decrease coverage by 34.06%.
The diff coverage is 55.22%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #427       +/-   ##
===========================================
- Coverage   87.13%   53.07%   -34.07%     
===========================================
  Files          99      112       +13     
  Lines        5067     5276      +209     
===========================================
- Hits         4415     2800     -1615     
- Misses        652     2476     +1824     
Impacted Files Coverage Δ
...na/transforms/decomposition/change_points_trend.py 40.95% <ø> (ø)
etna/transforms/decomposition/detrend.py 41.66% <ø> (ø)
etna/transforms/decomposition/stl.py 61.19% <ø> (ø)
etna/transforms/encoders/segment_encoder.py 42.10% <ø> (ø)
etna/transforms/feature_selection/base.py 45.00% <ø> (ø)
etna/transforms/feature_selection/filter.py 28.57% <ø> (ø)
etna/transforms/math/add_constant.py 61.90% <ø> (ø)
etna/transforms/math/lags.py 82.85% <ø> (ø)
etna/transforms/math/log.py 60.86% <ø> (ø)
etna/transforms/math/sklearn.py 29.90% <ø> (ø)
... and 97 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df238fc...9d1ee74. Read the comment docs.

@Mr-Geekman Mr-Geekman marked this pull request as ready for review December 29, 2021 14:01
@Mr-Geekman Mr-Geekman changed the title Clarify the behaviour of TimeSeriesImputerTransform in case of all NaN values Clarify the behaviour of TimeSeriesImputerTransform in case of all NaN values Dec 29, 2021
@Mr-Geekman Mr-Geekman merged commit 3eb2638 into master Dec 29, 2021
@Mr-Geekman Mr-Geekman deleted the issue-339 branch December 29, 2021 16:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] TimeSeriesImputerTransform can't fill nan-s if all values is NaN in mean setting
3 participants