-
Notifications
You must be signed in to change notification settings - Fork 80
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! 🥇
Possible issues:
You use strides mostly so we should not have problem with memory of 3-rank tensors.
But it seems we materialize 3-tensor there https://github.com/tinkoff-ai/etna/pull/625/files#diff-a835bd03f65917de399d66fdc3abb96f98627ed9c9b2a43c3004e2cca2166df2R487 for example.
Can we check memory consumtion?
It would be helpful to add dimension sizes to comments near variables in the important places.
🚀 Deployed on https://deploy-preview-625--etna-docs.netlify.app |
Codecov Report
@@ Coverage Diff @@
## master #625 +/- ##
==========================================
+ Coverage 84.12% 84.29% +0.16%
==========================================
Files 118 118
Lines 6243 6245 +2
==========================================
+ Hits 5252 5264 +12
+ Misses 991 981 -10
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
IMPORTANT: Please do not create a Pull Request without creating an issue first.
Before submitting (must do checklist)
Type of Change
Proposed Changes
Related Issue
Closing issues