Skip to content

Make statistics fast again #625

Merged
merged 12 commits into from
Apr 6, 2022
Merged

Make statistics fast again #625

merged 12 commits into from
Apr 6, 2022

Conversation

alex-hse-repository
Copy link
Collaborator

IMPORTANT: Please do not create a Pull Request without creating an issue first.

Before submitting (must do checklist)

  • Did you read the contribution guide?
  • Did you update the docs? We use Numpy format for all the methods and classes.
  • Did you write any new necessary tests?
  • Did you update the CHANGELOG?

Type of Change

  • Examples / docs / tutorials / contributors update
  • Bug fix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves an existing feature)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Proposed Changes

Related Issue

Closing issues

@alex-hse-repository alex-hse-repository added the enhancement New feature or request label Mar 24, 2022
@alex-hse-repository alex-hse-repository self-assigned this Mar 24, 2022
@alex-hse-repository alex-hse-repository marked this pull request as draft March 24, 2022 16:09
@alex-hse-repository
Copy link
Collaborator Author

Снимок экрана 2022-03-24 в 19 23 14

Copy link
Contributor

@martins0n martins0n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 🥇

Possible issues:
You use strides mostly so we should not have problem with memory of 3-rank tensors.
But it seems we materialize 3-tensor there https://github.com/tinkoff-ai/etna/pull/625/files#diff-a835bd03f65917de399d66fdc3abb96f98627ed9c9b2a43c3004e2cca2166df2R487 for example.
Can we check memory consumtion?

It would be helpful to add dimension sizes to comments near variables in the important places.

@martins0n martins0n marked this pull request as ready for review March 25, 2022 10:44
@martins0n martins0n closed this Mar 25, 2022
@martins0n martins0n reopened this Mar 25, 2022
@martins0n martins0n closed this Mar 25, 2022
@martins0n martins0n reopened this Mar 25, 2022
@github-actions
Copy link

github-actions bot commented Apr 4, 2022

🚀 Deployed on https://deploy-preview-625--etna-docs.netlify.app

@github-actions github-actions bot temporarily deployed to pull request April 4, 2022 09:11 Inactive
@codecov-commenter
Copy link

codecov-commenter commented Apr 4, 2022

Codecov Report

Merging #625 (5045e6d) into master (858e894) will increase coverage by 0.16%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #625      +/-   ##
==========================================
+ Coverage   84.12%   84.29%   +0.16%     
==========================================
  Files         118      118              
  Lines        6243     6245       +2     
==========================================
+ Hits         5252     5264      +12     
+ Misses        991      981      -10     
Impacted Files Coverage Δ
etna/transforms/math/statistics.py 99.28% <100.00%> (+0.74%) ⬆️
etna/transforms/nn/pytorch_forecasting.py 95.23% <0.00%> (+4.76%) ⬆️
etna/models/nn/tft.py 100.00% <0.00%> (+8.19%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@github-actions github-actions bot temporarily deployed to pull request April 4, 2022 09:37 Inactive
martins0n
martins0n previously approved these changes Apr 5, 2022
Copy link
Contributor

@martins0n martins0n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@martins0n martins0n enabled auto-merge (squash) April 6, 2022 07:20
@github-actions github-actions bot temporarily deployed to pull request April 6, 2022 07:23 Inactive
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants