Skip to content

Improve formatting of documentation #636

Merged
merged 39 commits into from
Apr 12, 2022
Merged

Improve formatting of documentation #636

merged 39 commits into from
Apr 12, 2022

Conversation

Mr-Geekman
Copy link
Contributor

@Mr-Geekman Mr-Geekman commented Apr 5, 2022

IMPORTANT: Please do not create a Pull Request without creating an issue first.

Before submitting (must do checklist)

  • Did you read the contribution guide?
  • Did you update the docs? We use Numpy format for all the methods and classes.
  • Did you write any new necessary tests?
  • Did you update the CHANGELOG?

Type of Change

  • Examples / docs / tutorials / contributors update
  • Bug fix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves an existing feature)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Proposed Changes

Look #631.

Related Issue

#631.

Closing issues

Closes #631.

@Mr-Geekman Mr-Geekman added the documentation Improvements or additions to documentation label Apr 5, 2022
@Mr-Geekman Mr-Geekman self-assigned this Apr 5, 2022
@github-actions
Copy link

github-actions bot commented Apr 5, 2022

🚀 Deployed on https://deploy-preview-636--etna-docs.netlify.app

@github-actions github-actions bot temporarily deployed to pull request April 5, 2022 15:34 Inactive
@codecov-commenter
Copy link

codecov-commenter commented Apr 5, 2022

Codecov Report

Merging #636 (18fb11e) into master (504d1f7) will decrease coverage by 31.68%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           master     #636       +/-   ##
===========================================
- Coverage   84.32%   52.63%   -31.69%     
===========================================
  Files         118      118               
  Lines        6263     6264        +1     
===========================================
- Hits         5281     3297     -1984     
- Misses        982     2967     +1985     
Impacted Files Coverage Δ
etna/analysis/change_points_trend/search.py 35.71% <ø> (ø)
etna/analysis/eda_utils.py 21.54% <ø> (-27.28%) ⬇️
etna/analysis/feature_relevance/relevance.py 61.76% <ø> (-35.30%) ⬇️
etna/analysis/feature_relevance/relevance_table.py 33.33% <ø> (-66.67%) ⬇️
etna/analysis/feature_selection/mrmr_selection.py 32.35% <ø> (ø)
etna/analysis/outliers/density_outliers.py 22.44% <ø> (-75.52%) ⬇️
etna/analysis/outliers/hist_outliers.py 10.82% <ø> (-66.25%) ⬇️
etna/analysis/outliers/median_outliers.py 25.00% <ø> (-70.84%) ⬇️
.../analysis/outliers/prediction_interval_outliers.py 33.33% <ø> (-57.58%) ⬇️
etna/analysis/plotters.py 10.99% <ø> (-9.96%) ⬇️
... and 142 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@github-actions github-actions bot temporarily deployed to pull request April 5, 2022 16:16 Inactive
@github-actions github-actions bot temporarily deployed to pull request April 5, 2022 17:00 Inactive
@github-actions github-actions bot temporarily deployed to pull request April 6, 2022 07:51 Inactive
@github-actions github-actions bot temporarily deployed to pull request April 6, 2022 08:15 Inactive
@github-actions github-actions bot temporarily deployed to pull request April 6, 2022 08:58 Inactive
@github-actions github-actions bot temporarily deployed to pull request April 6, 2022 09:36 Inactive
@github-actions github-actions bot temporarily deployed to pull request April 6, 2022 12:55 Inactive
@github-actions github-actions bot temporarily deployed to pull request April 6, 2022 14:13 Inactive
@github-actions github-actions bot temporarily deployed to pull request April 8, 2022 14:18 Inactive
@github-actions github-actions bot temporarily deployed to pull request April 11, 2022 08:43 Inactive
@github-actions github-actions bot temporarily deployed to pull request April 11, 2022 09:24 Inactive
if True with flatten index
* If False, return pd.DataFrame with multiindex

* if True, return with flatten index
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* if True, return with flatten index
* If True, return with flatten index

If `job_type` or `group` isn't set then only one-level subfolder is created.
If none of `job_type` and `group` is set then experiment logs files into `self.experiment_folder`.
As a result, within ``self.experiment_folder`` subfolder ``job_type/group`` is created.
If ``job_type`` or ``group`` isn't set then only one-level subfolder is created.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You've added bulletpoints in such cases before

@@ -33,7 +33,7 @@ def _save_original_values(self, ts: TSDataset):

Parameters
----------
ts:
ts: TSDataset
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something unusual?

@@ -102,15 +102,19 @@ def plot_forecast(
----------
forecast_ts:
there are several options:

1. Forecasted TSDataset with timeseries data, single-forecast mode
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@github-actions github-actions bot temporarily deployed to pull request April 11, 2022 10:57 Inactive
@github-actions github-actions bot temporarily deployed to pull request April 11, 2022 11:12 Inactive
# Conflicts:
#	etna/transforms/missing_values/imputation.py
@github-actions github-actions bot temporarily deployed to pull request April 11, 2022 13:56 Inactive
@github-actions github-actions bot temporarily deployed to pull request April 12, 2022 07:39 Inactive
@github-actions github-actions bot temporarily deployed to pull request April 12, 2022 09:53 Inactive
@github-actions github-actions bot temporarily deployed to pull request April 12, 2022 10:56 Inactive
@martins0n martins0n enabled auto-merge (squash) April 12, 2022 11:07
@martins0n martins0n merged commit 6c52e29 into master Apr 12, 2022
@martins0n martins0n deleted the issue-631 branch April 12, 2022 11:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[docs] Documentation formatting
3 participants