Skip to content

Attempt to fix bug with exogs in AutoRegressivePipeline #647

Merged
merged 7 commits into from
Apr 12, 2022
Merged

Conversation

Mr-Geekman
Copy link
Contributor

@Mr-Geekman Mr-Geekman commented Apr 12, 2022

IMPORTANT: Please do not create a Pull Request without creating an issue first.

Before submitting (must do checklist)

  • Did you read the contribution guide?
  • Did you update the docs? We use Numpy format for all the methods and classes.
  • Did you write any new necessary tests?
  • Did you update the CHANGELOG?

Type of Change

  • Examples / docs / tutorials / contributors update
  • Bug fix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves an existing feature)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Proposed Changes

  1. Create current_ts in AutoRegressivePipeline._forecast with exogs.
  2. Recreate prediction forecast from scratch with exogs at the end of AutoRegressivePipeline._forecast.

Related Issue

#570.

Closing issues

Closes #570.

@Mr-Geekman Mr-Geekman added the bug Something isn't working label Apr 12, 2022
@Mr-Geekman Mr-Geekman self-assigned this Apr 12, 2022
@github-actions
Copy link

github-actions bot commented Apr 12, 2022

🚀 Deployed on https://deploy-preview-647--etna-docs.netlify.app

@github-actions github-actions bot temporarily deployed to pull request April 12, 2022 12:24 Inactive
@codecov-commenter
Copy link

codecov-commenter commented Apr 12, 2022

Codecov Report

Merging #647 (8298044) into master (6c52e29) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #647   +/-   ##
=======================================
  Coverage   84.33%   84.33%           
=======================================
  Files         118      118           
  Lines        6268     6270    +2     
=======================================
+ Hits         5286     5288    +2     
  Misses        982      982           
Impacted Files Coverage Δ
etna/pipeline/autoregressive_pipeline.py 95.83% <100.00%> (+0.18%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@github-actions github-actions bot temporarily deployed to pull request April 12, 2022 14:22 Inactive
@github-actions github-actions bot temporarily deployed to pull request April 12, 2022 14:33 Inactive
Copy link
Contributor

@martins0n martins0n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@martins0n martins0n enabled auto-merge (squash) April 12, 2022 15:11
@github-actions github-actions bot temporarily deployed to pull request April 12, 2022 15:15 Inactive
@martins0n martins0n merged commit 9b608c9 into master Apr 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] AutoRegressivePipeline does not handle exog features correctly
3 participants