Implemented Addresser setters have no effect

[TirelessDev]

The Addresser interface declares the Set(val string) and SetRandom(bool) receivers but all implementations implement these as value receivers that ineffectively attempt to modify their own state. This is triggering the go static check SA4005.

bluetooth/gap_darwin.go

Lines 27 to 33 in e79ea1e

	func (ad Address) Set(val string) {
	uuid, err := ParseUUID(val)
	if err != nil {
	return
	}
	ad.UUID = uuid
	}

These implementations should be pointer receivers but changing them will unfortunately modify the API. All Address objects would need to be passed around as *Address pointers as the Address type will no longer implement the Addresser interface. This is most obvious in func (a *Adapter) Connect(address Addresser, params ConnectionParams) (*Device, error).

[deadprogram]

See the recent updates to dev which change this in order to avoid heap allocations.

[aykevl]

This is indeed a bug, thanks for spotting it!
Here is a fix: #158

These implementations should be pointer receivers but changing them will unfortunately modify the API. All Address objects would need to be passed around as *Address pointers as the Address type will no longer implement the Addresser interface.

At least with the current dev branch, no API change is necessary.

[TirelessDev]

Awesome! Thanks all, the changes look good. I have also updated PR #149 to reflect the latest dev.