Suggestion to make function HAL internal and Interface HAL public #797
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HattoriHanzo031
force-pushed
the
pin-hal2-discussion
branch
from
6ae0c4a to
bc6e8e4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is based on #795 with function HAL being moved to internal and interface HAL being made public. onewire, dht and uc8151 drivers are refactored to demonstrate how would the drivers be refactored to eliminate dependency on machine package while preserving backward compatibility and performance. Also onewire_v2 mock driver was added to simulate adding new drivers in future that use the same pin as both input and output.