Group together STM32 smoke tests. #1718
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QuLogic
force-pushed
the
group-smoketests
branch
from
c657b24 to
bd9a3e3
Compare
|
Can you please resolve the current merge conflict @QuLogic thanks. |
And then allow them to be disabled with one option.
QuLogic
force-pushed
the
group-smoketests
branch
from
bd9a3e3 to
0b052e2
Compare
|
Thanks @QuLogic now merging. |
|
Hmm, that's unfortunate. But if you say so... I hope ST will eventually add a license to these files, it's weird they don't. (At the same time I think it's very unlikely they will sue anybody for using the SVD files for their own chips). |
|
Alas, there is a license, but it's not open source friendly: https://github.com/posborne/cmsis-svd/blob/master/data/STMicro/License.html I did ask on their forums, and they did say they'd look into it, but who knows. Maybe with more ARM vendors using ASL2.0/BSD, they might start releasing it that way too, but it may only be for new files. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And then allow them to be disabled with one option.
Unfortunately, I can't ship the STM32 svd files because of their license, so I need an easy way to skip these smoke tests. This option is similar to the
AVRandXTENSAones.