Add tinygo version subcommand #172
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n. Also displayed when usage is displayed Signed-off-by: Ron Evans <ron@hybridgroup.com>
aykevl
reviewed
Feb 7, 2019
There was a problem hiding this comment.
I think this can be much simpler:
// in version.go:
const version = "0.1" // or 0.1.0
// in the subcommand switch
case "version":
fmt.Printf("tinygo version %s %s/%s", version, runtime.GOOS(), runtime.GOARCH())
// in usage()
fmt.Fprintln(os.Stderr, "TinyGo is a Go compiler for small places.")
fmt.Fprintln(os.Stderr, "version:", version)
main.go
Outdated
| usage() | ||
| case "version": | ||
| fmt.Fprintln(os.Stderr, displayversion()) | ||
| version() |
There was a problem hiding this comment.
A call to version that doesn't do anything?
main.go
Outdated
| case "help": | ||
| usage() | ||
| case "version": | ||
| fmt.Fprintln(os.Stderr, displayversion()) |
There was a problem hiding this comment.
The name displayversion suggests to me that this function actually prints the version.
version.go
Outdated
|
|
||
| // tinyGoVersion of this package. | ||
| // Update this value before release of new version of software. | ||
| const tinyGoVersion = "0.1.0" |
There was a problem hiding this comment.
The current tag is v0.1, not v0.1.0. Go uses the former, semver uses the latter. I'm fine with both, but I think they should be aligned.
There was a problem hiding this comment.
I suggest we use x.y.z format to make it explicit.
Signed-off-by: Ron Evans <ron@hybridgroup.com>
|
Updates pushed. |
…mand does Signed-off-by: Ron Evans <ron@hybridgroup.com>
|
OK, cool. Merging into dev. |
deadprogram
added a commit
that referenced
this pull request
Feb 19, 2019
* cmd: add tinygo version subcommand to display current software version. Also displayed when usage is displayed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
tinygo versionsubcommand to display the current version of the TinyGo compiler:The same info is displayed alongside the usage info.