loader: support global variables in CGo #173
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Global variables (like functions) must be declared in the import "C" preamble and can then be used from Go.
Merged
|
Amazing how much you need to implement that one feature. Anyhow, this seems like it should be able to be merged now, since it does not impact any non-CGo functionality from what I can tell. What do you think? |
Yes it's a pretty big change, because initial assumptions about how to structure code turned out to be somewhat wrong. There are even more changes in #174 for the same reason. |
|
OK now merging. |
deadprogram
pushed a commit
that referenced
this pull request
Feb 19, 2019
Global variables (like functions) must be declared in the import "C" preamble and can then be used from Go.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Global variables (like functions) must be declared in the import "C"
preamble and can then be used from Go.