PWM Support for atmega1280 #1798
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add arduino mega 1280 PWM test
|
I tested all the 6 timers and everything is working properly and is ready to review |
|
I have a 2560 but did not have time to locate it to test with this PR. Looks good, so now merging. Thanks @MrNinso for another great contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the initial pwm support for atmega1280
I need to test this code a little bit more on my arduino mega 1280 before became ready for review, but suggestions and fixes are welcome.
this code is theoretically working on atmega2560, but I don't have an arduino mega 2560, but if anyone can test this I will add it to this pull request.
this code is based in #1121