Define intrinsic functions #2920
Merged
+131
−78
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Failure is due to the definition of the |
This changes the compiler from treating calls to sync/atomic.* functions as special calls (emitted directly at the call site) to actually defining their declarations when there is no Go SSA implementation. And rely on the inliner to inline these very small functions. This works a bit better in practice. For example, this makes it possible to use these functions in deferred function calls. This commit is a bit large because it also needs to refactor a few things to make it possible to define such intrinsic functions.
This makes them available to deferred calls, among others.
This makes it possible to //go:linkname them from other places, like in the reflect package. And is in my opinion a much cleaner solution.
aykevl
force-pushed
the
define-intrinsic-functions
branch
from
47d487b to
c425be0
Compare
|
Thank you for debugging! This should be fixed now. |
|
Reran the tinyhci checks -- they're passing now. |
aykevl
added a commit
that referenced
this pull request
Aug 28, 2022
Instead of changing the calls, replace the function bodies themselves. This is useful for a number of reasons, see #2920 for more information. I have removed the math intrinsics tests because they are no longer useful. Instead, I think `tinygo test math` should suffice.
aykevl
added a commit
that referenced
this pull request
Aug 28, 2022
Instead of changing the calls, replace the function bodies themselves. This is useful for a number of reasons, see #2920 for more information. I have removed the math intrinsics tests because they are no longer useful. Instead, I think `tinygo test math` should suffice.
aykevl
added a commit
that referenced
this pull request
Aug 30, 2022
Instead of changing the calls, replace the function bodies themselves. This is useful for a number of reasons, see #2920 for more information. I have removed the math intrinsics tests because they are no longer useful. Instead, I think `tinygo test math` should suffice.
aykevl
added a commit
that referenced
this pull request
Aug 30, 2022
Instead of changing the calls, replace the function bodies themselves. This is useful for a number of reasons, see #2920 for more information. I have removed the math intrinsics tests because they are no longer useful. Instead, I think `tinygo test math` should suffice.
aykevl
added a commit
that referenced
this pull request
Aug 30, 2022
Instead of changing the calls, replace the function bodies themselves. This is useful for a number of reasons, see #2920 for more information. I have removed the math intrinsics tests because they are no longer useful. Instead, I think `tinygo test math` should suffice.
deadprogram
pushed a commit
that referenced
this pull request
Aug 30, 2022
Instead of changing the calls, replace the function bodies themselves. This is useful for a number of reasons, see #2920 for more information. I have removed the math intrinsics tests because they are no longer useful. Instead, I think `tinygo test math` should suffice.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #2652 by implementing various compiler intrinsics as real functions. Also see #2821 (comment) and #2805.
I think it makes sense to move a few more functions over if possible, like the system call functions and
runtime.supportsRecover. But this can be done at a later time.